From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>
Cc: Networking <netdev@vger.kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Linux Kbuild mailing list" <linux-kbuild@vger.kernel.org>,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig
Date: Wed, 2 Oct 2019 10:48:54 +0900 [thread overview]
Message-ID: <CAK7LNATD4vCQnNsHXP8A2cyWDkCNX=LGh0ej-dkDajm-+Lfw8Q@mail.gmail.com> (raw)
In-Reply-To: <CAJ+HfNgvxornSfqnbAthNy6u6=-enGCdA8K1e6rLXhCzGgmONQ@mail.gmail.com>
On Tue, Oct 1, 2019 at 11:16 PM Björn Töpel <bjorn.topel@gmail.com> wrote:
>
> On Tue, 1 Oct 2019 at 14:33, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > Hi Bjorn
> >
> > On Tue, Oct 1, 2019 at 7:14 PM Björn Töpel <bjorn.topel@gmail.com> wrote:
> > >
> [...]
> > > subdir-$(CONFIG_SAMPLE_VFS) += vfs
> > > +subdir-$(CONFIG_SAMPLE_BPF) += bpf
> >
> >
> > Please keep samples/Makefile sorted alphabetically.
> >
>
> Thank you, I'll address that in the v2!
>
> >
> >
> >
> > I am not checking samples/bpf/Makefile, but
> > allmodconfig no longer compiles for me.
> >
> >
> >
> > samples/bpf/Makefile:209: WARNING: Detected possible issues with include path.
> > samples/bpf/Makefile:210: WARNING: Please install kernel headers
> > locally (make headers_install).
> > error: unable to create target: 'No available targets are compatible
> > with triple "bpf"'
> > 1 error generated.
> > readelf: Error: './llvm_btf_verify.o': No such file
> > *** ERROR: LLVM (llc) does not support 'bpf' target
> > NOTICE: LLVM version >= 3.7.1 required
> >
So, samples/bpf intentionally opts out the normal build
because most of people fail to build it.
It must be fixed somehow
before supporting it in samples/Makefile.
> Yes, the BPF samples require clang/LLVM with BPF support to build. Any
> suggestion on a good way to address this (missing tools), better than
> the warning above? After the commit 394053f4a4b3 ("kbuild: make single
> targets work more correctly"), it's no longer possible to build
> samples/bpf without support in the samples/Makefile.
You can with
"make M=samples/bpf"
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-10-02 1:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 10:14 [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig Björn Töpel
2019-10-01 10:17 ` Björn Töpel
2019-10-01 12:33 ` Masahiro Yamada
2019-10-01 14:16 ` Björn Töpel
2019-10-02 1:48 ` Masahiro Yamada [this message]
2019-10-02 7:41 ` Björn Töpel
2019-10-02 23:14 ` Ivan Khoronzhuk
2019-10-03 6:28 ` Björn Töpel
2019-10-03 10:36 ` Masahiro Yamada
2019-10-03 10:50 ` Björn Töpel
2019-10-03 17:16 ` Andrii Nakryiko
2019-10-03 17:37 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATD4vCQnNsHXP8A2cyWDkCNX=LGh0ej-dkDajm-+Lfw8Q@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).