bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>
Cc: Networking <netdev@vger.kernel.org>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Linux Kbuild mailing list" <linux-kbuild@vger.kernel.org>,
	bpf@vger.kernel.org
Subject: Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig
Date: Tue, 1 Oct 2019 21:33:00 +0900	[thread overview]
Message-ID: <CAK7LNATNw4Qysj1Q2dXd4PALfbtgMXPwgvmW=g0dRcrczGW-Fg@mail.gmail.com> (raw)
In-Reply-To: <20191001101429.24965-1-bjorn.topel@gmail.com>

Hi Bjorn

On Tue, Oct 1, 2019 at 7:14 PM Björn Töpel <bjorn.topel@gmail.com> wrote:
>
> From: Björn Töpel <bjorn.topel@intel.com>
>
> This commit makes it possible to build the BPF samples via a Kconfig
> option, CONFIG_SAMPLE_BPF. Further, it fixes that samples/bpf/ could
> not be built due to a missing samples/Makefile subdir-y entry, after
> the introduction of commit 394053f4a4b3 ("kbuild: make single targets
> work more correctly").
>
> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
> ---
>  samples/Kconfig  | 4 ++++
>  samples/Makefile | 1 +
>  2 files changed, 5 insertions(+)
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index c8dacb4dda80..054297ac89ad 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -169,4 +169,8 @@ config SAMPLE_VFS
>           as mount API and statx().  Note that this is restricted to the x86
>           arch whilst it accesses system calls that aren't yet in all arches.
>
> +config SAMPLE_BPF
> +       bool "BPF samples"
> +       depends on HEADERS_INSTALL
> +
>  endif # SAMPLES
> diff --git a/samples/Makefile b/samples/Makefile
> index 7d6e4ca28d69..49aa2f7d044b 100644
> --- a/samples/Makefile
> +++ b/samples/Makefile
> @@ -20,3 +20,4 @@ obj-$(CONFIG_SAMPLE_TRACE_PRINTK)     += trace_printk/
>  obj-$(CONFIG_VIDEO_PCI_SKELETON)       += v4l/
>  obj-y                                  += vfio-mdev/
>  subdir-$(CONFIG_SAMPLE_VFS)            += vfs
> +subdir-$(CONFIG_SAMPLE_BPF)            += bpf


Please keep samples/Makefile sorted alphabetically.




I am not checking samples/bpf/Makefile, but
allmodconfig no longer compiles for me.



samples/bpf/Makefile:209: WARNING: Detected possible issues with include path.
samples/bpf/Makefile:210: WARNING: Please install kernel headers
locally (make headers_install).
error: unable to create target: 'No available targets are compatible
with triple "bpf"'
1 error generated.
readelf: Error: './llvm_btf_verify.o': No such file
*** ERROR: LLVM (llc) does not support 'bpf' target
   NOTICE: LLVM version >= 3.7.1 required

-- 
Best Regards
Masahiro Yamada

  parent reply	other threads:[~2019-10-01 12:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 10:14 [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig Björn Töpel
2019-10-01 10:17 ` Björn Töpel
2019-10-01 12:33 ` Masahiro Yamada [this message]
2019-10-01 14:16   ` Björn Töpel
2019-10-02  1:48     ` Masahiro Yamada
2019-10-02  7:41       ` Björn Töpel
2019-10-02 23:14         ` Ivan Khoronzhuk
2019-10-03  6:28           ` Björn Töpel
2019-10-03 10:36             ` Masahiro Yamada
2019-10-03 10:50               ` Björn Töpel
2019-10-03 17:16                 ` Andrii Nakryiko
2019-10-03 17:37                   ` Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNATNw4Qysj1Q2dXd4PALfbtgMXPwgvmW=g0dRcrczGW-Fg@mail.gmail.com' \
    --to=yamada.masahiro@socionext.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@gmail.com \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).