From: Stanislav Fomichev <sdf@google.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH bpf-next v2 0/3] libbpf: use func name when pinning programs with LIBBPF_STRICT_SEC_NAME
Date: Wed, 20 Oct 2021 11:22:03 -0700 [thread overview]
Message-ID: <CAKH8qBt5dLs8UN4YnRj7mkG2KmqrRKLj5QTGdFZ-OKDkz+vkwQ@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzZ0-BeNmd9AuyLF1QZvmH4xNjAXPC2TsUN++D2WkuN5UQ@mail.gmail.com>
On Wed, Oct 20, 2021 at 11:14 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Tue, Oct 12, 2021 at 9:15 AM Stanislav Fomichev <sdf@google.com> wrote:
> >
> > Commit 15669e1dcd75 ("selftests/bpf: Normalize all the rest SEC() uses")
> > broke flow dissector tests. With the strict section names, bpftool isn't
> > able to pin all programs of the objects (all section names are the
> > same now). To bring it back to life let's do the following:
> >
> > - teach libbpf to pin by func name with LIBBPF_STRICT_SEC_NAME
> > - enable strict mode in bpftool (breaking cli change)
> > - fix custom flow_dissector loader to use strict mode
> > - fix flow_dissector tests to use new pin names (func vs sec)
> >
> > v2:
> > - add github issue (Andrii Nakryiko)
> > - remove sec_name from bpf_program.pin_name comment (Andrii Nakryiko)
> > - clarify program pinning in LIBBPF_STRICT_SEC_NAME (Andrii Nakryiko)
>
> I could not find this, can you please point me to where this is
> clarified/explained in your patches?
Sorry, I don't see it either. I remember I've added some comment to
LIBBPF_STRICT_SEC_NAME in tools/lib/bpf/libbpf_legacy.h but I don't
see it in the paches / my local tree. Will add back and resend.
>
> > - add cover letter (Andrii Nakryiko)
> >
> > Stanislav Fomichev (3):
> > libbpf: use func name when pinning programs with
> > LIBBPF_STRICT_SEC_NAME
> > bpftool: don't append / to the progtype
> > selftests/bpf: fix flow dissector tests
> >
> > tools/bpf/bpftool/main.c | 4 ++++
> > tools/bpf/bpftool/prog.c | 15 +--------------
> > tools/lib/bpf/libbpf.c | 10 ++++++++--
> > .../selftests/bpf/flow_dissector_load.c | 18 +++++++++++-------
> > .../selftests/bpf/flow_dissector_load.h | 10 ++--------
> > .../selftests/bpf/test_flow_dissector.sh | 10 +++++-----
> > 6 files changed, 31 insertions(+), 36 deletions(-)
> >
> > --
> > 2.33.0.882.g93a45727a2-goog
> >
prev parent reply other threads:[~2021-10-20 18:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 16:15 [PATCH bpf-next v2 0/3] libbpf: use func name when pinning programs with LIBBPF_STRICT_SEC_NAME Stanislav Fomichev
2021-10-12 16:15 ` [PATCH bpf-next v2 1/3] " Stanislav Fomichev
2021-10-20 18:14 ` Andrii Nakryiko
2021-10-12 16:15 ` [PATCH bpf-next v2 2/3] bpftool: don't append / to the progtype Stanislav Fomichev
2021-10-20 18:12 ` Andrii Nakryiko
2021-10-20 22:46 ` Stanislav Fomichev
2021-10-12 16:15 ` [PATCH bpf-next v2 3/3] selftests/bpf: fix flow dissector tests Stanislav Fomichev
2021-10-20 18:14 ` [PATCH bpf-next v2 0/3] libbpf: use func name when pinning programs with LIBBPF_STRICT_SEC_NAME Andrii Nakryiko
2021-10-20 18:22 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKH8qBt5dLs8UN4YnRj7mkG2KmqrRKLj5QTGdFZ-OKDkz+vkwQ@mail.gmail.com \
--to=sdf@google.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).