From: Stanislav Fomichev <sdf@google.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>, Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf] bpf: fix XDP FD-based attach/detach logic around XDP_FLAGS_UPDATE_IF_NOEXIST
Date: Wed, 12 Aug 2020 08:47:06 -0700 [thread overview]
Message-ID: <CAKH8qBuz48Ww6S=DCzKRr3f46Eq3LyknvTjDGP_5QRPxtGZ_Hw@mail.gmail.com> (raw)
In-Reply-To: <87imdo1ajl.fsf@toke.dk>
On Wed, Aug 12, 2020 at 2:24 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
> Andrii Nakryiko <andriin@fb.com> writes:
>
> > Enforce XDP_FLAGS_UPDATE_IF_NOEXIST only if new BPF program to be attached is
> > non-NULL (i.e., we are not detaching a BPF program).
> >
> > Reported-by: Stanislav Fomichev <sdf@google.com>
> > Fixes: d4baa9368a5e ("bpf, xdp: Extract common XDP program attachment logic")
> > Signed-off-by: Andrii Nakryiko <andriin@fb.com>
>
> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
That fixed it for me, thank you!
Tested-by: Stanislav Fomichev <sdf@google.com>
next prev parent reply other threads:[~2020-08-12 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 2:29 [PATCH bpf] bpf: fix XDP FD-based attach/detach logic around XDP_FLAGS_UPDATE_IF_NOEXIST Andrii Nakryiko
2020-08-12 9:24 ` Toke Høiland-Jørgensen
2020-08-12 15:47 ` Stanislav Fomichev [this message]
2020-08-13 1:08 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKH8qBuz48Ww6S=DCzKRr3f46Eq3LyknvTjDGP_5QRPxtGZ_Hw@mail.gmail.com' \
--to=sdf@google.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).