From: Alexander Duyck <alexander.duyck@gmail.com>
To: bpf <bpf@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Kernel Team <kernel-team@fb.com>, Netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Lawrence Brakmo <brakmo@fb.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
alexanderduyck@fb.com
Subject: Re: [bpf-next PATCH v2 0/5] selftests/bpf: Migrate test_tcpbpf_user to be a part of test_progs framework
Date: Sat, 31 Oct 2020 12:03:32 -0700 [thread overview]
Message-ID: <CAKgT0Ue+E6krF8=uqXDGDC095_mcDKNB1T2kc+uow3ywk3-RSQ@mail.gmail.com> (raw)
In-Reply-To: <160416890683.710453.7723265174628409401.stgit@localhost.localdomain>
On Sat, Oct 31, 2020 at 11:31 AM Alexander Duyck
<alexander.duyck@gmail.com> wrote:
>
> Move the test functionality from test_tcpbpf_user into the test_progs
> framework so that it will be run any time the test_progs framework is run.
> This will help to prevent future test escapes as the individual tests, such
> as test_tcpbpf_user, are less likely to be run by developers and CI
> tests.
>
> As a part of moving it over the series goes through and updates the code to
> make use of the existing APIs included in the test_progs framework. This is
> meant to simplify and streamline the test code and avoid duplication of
> effort.
>
> v2: Dropped test_tcpbpf_user from .gitignore
> Replaced CHECK_FAIL calls with CHECK calls
> Minimized changes in patch 1 when moving the file
> Updated stg mail command line to display renames in submission
> Added shutdown logic to end of run_test function to guarantee close
> Added patch that replaces the two maps with use of global variables
>
> ---
>
> Alexander Duyck (5):
> selftests/bpf: Move test_tcppbf_user into test_progs
> selftests/bpf: Drop python client/server in favor of threads
> selftests/bpf: Replace EXPECT_EQ with ASSERT_EQ and refactor verify_results
> selftests/bpf: Migrate tcpbpf_user.c to use BPF skeleton
> selftest/bpf: Use global variables instead of maps for test_tcpbpf_kern
>
>
> .../selftests/bpf/prog_tests/tcpbpf_user.c | 239 +++++++++---------
> .../selftests/bpf/progs/test_tcpbpf_kern.c | 86 +------
> tools/testing/selftests/bpf/tcp_client.py | 50 ----
> tools/testing/selftests/bpf/tcp_server.py | 80 ------
> tools/testing/selftests/bpf/test_tcpbpf.h | 2 +
> 5 files changed, 135 insertions(+), 322 deletions(-)
> delete mode 100755 tools/testing/selftests/bpf/tcp_client.py
> delete mode 100755 tools/testing/selftests/bpf/tcp_server.py
>
> --
It looks like the "--to" on the cover page was dropped and it wasn't
delivered to the bpf mailing list. So I am just going to reply to the
one that was delivered to netdev so that it is visible for the people
on the bpf list.
Thanks.
- Alex
prev parent reply other threads:[~2020-10-31 19:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <160416890683.710453.7723265174628409401.stgit@localhost.localdomain>
2020-10-31 18:52 ` [bpf-next PATCH v2 1/5] selftests/bpf: Move test_tcppbf_user into test_progs Alexander Duyck
2020-11-03 18:34 ` Andrii Nakryiko
2020-11-03 19:06 ` Alexander Duyck
2020-10-31 18:52 ` [bpf-next PATCH v2 2/5] selftests/bpf: Drop python client/server in favor of threads Alexander Duyck
2020-11-03 0:38 ` Martin KaFai Lau
2020-11-03 0:49 ` Alexander Duyck
2020-11-03 1:33 ` Martin KaFai Lau
2020-11-03 16:01 ` Alexander Duyck
2020-10-31 18:52 ` [bpf-next PATCH v2 3/5] selftests/bpf: Replace EXPECT_EQ with ASSERT_EQ and refactor verify_results Alexander Duyck
2020-11-03 0:42 ` Martin KaFai Lau
2020-11-03 0:56 ` Alexander Duyck
2020-11-03 1:40 ` Martin KaFai Lau
2020-11-03 18:38 ` Andrii Nakryiko
2020-10-31 18:52 ` [bpf-next PATCH v2 4/5] selftests/bpf: Migrate tcpbpf_user.c to use BPF skeleton Alexander Duyck
2020-11-03 0:55 ` Martin KaFai Lau
2020-11-03 15:44 ` Alexander Duyck
2020-10-31 18:52 ` [bpf-next PATCH v2 5/5] selftest/bpf: Use global variables instead of maps for test_tcpbpf_kern Alexander Duyck
2020-11-03 1:25 ` Martin KaFai Lau
2020-11-03 15:42 ` Alexander Duyck
2020-11-03 18:12 ` Martin KaFai Lau
2020-11-03 18:40 ` Andrii Nakryiko
2020-10-31 19:03 ` Alexander Duyck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKgT0Ue+E6krF8=uqXDGDC095_mcDKNB1T2kc+uow3ywk3-RSQ@mail.gmail.com' \
--to=alexander.duyck@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brakmo@fb.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).