From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E372C433DB for ; Fri, 5 Feb 2021 00:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EACD64FB8 for ; Fri, 5 Feb 2021 00:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbhBEAFf (ORCPT ); Thu, 4 Feb 2021 19:05:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231433AbhBEAFd (ORCPT ); Thu, 4 Feb 2021 19:05:33 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA857C06178A for ; Thu, 4 Feb 2021 16:04:53 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id t25so3289441pga.2 for ; Thu, 04 Feb 2021 16:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WuuWQCiwdV87iW0z7KxVY5BTEgeNizYr5qdipOfxXnc=; b=hJu87bCSyR1Kv3ijwZbkKNvs01VCINeDtrWjeRxX0TBc8YFS0tk3FKL/zdwi5VP7td PlI3K7mcZso4bJEOtv2rLoBj6TsGxU5HNATT/olyMpUxY4HRuKpdwLeygD5lQ8xJXyOp 8asM747S5Mmf6ZQXTnIFYFS2YDOaPVm7uCVnAZHlVeCEVMxQ/t1wP3+dug/EL2QxGaN6 venL6y4MmxsBhkB5uiilZ5lgZBP8TP8wJsjgmE9Nxna2IKtbRPWfJKVmMg86FnHWsU3p boUZ8oswAq6lgYMKhYI1r5M8OCCIaXcU2dNcitOPz+jh/6ehx6tlLGeezWQwGD5UU9Ze SQNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WuuWQCiwdV87iW0z7KxVY5BTEgeNizYr5qdipOfxXnc=; b=a9dRMrg+DTw1foQF7Jr0Ntbc+CzPiOjh24N66++bcoobjVETx3iy2ftJFCQ3ddzcxh QT0bK5goP3PbUopyfx6LQ6Q9lkPaUJ7SopzR2GLHWq87FXXcXzRPeRXtYx2J7QFpLC4M vwX/FVqufOvKMV/6qbJMA5TnkEE5fnmUshC7PuycBicaoP5x6Kam5AHiP2CmITPsJgt7 rFiAI5NR/eqCi3wmmqI4m2Fi8M3CfZgqWsvUzYLYPst38NKk2LTHST7MI5KhMMUFt5sn dEronW7LQd05c1inNam7/vf/HmEG3fzmcdT6E4lNLePowkDK6qhQIr3fxD4fToz6Hr5E EYgA== X-Gm-Message-State: AOAM530UJWywiXQ4CroxLMm+orzaKeT9ODauHmIw8CNksgTCbC3UtlMM pzocpPKxxRvcwu81RMxdCI4kJZylD1DQIvAwru9J/w== X-Google-Smtp-Source: ABdhPJxiqPOP+t9zseOEfIyIpqMaTUgdxO3foYKfOGifXc4uOhxBTBoT0OVMHzFKRSkn1upcNYcLbnRumZUT3uow9Yg= X-Received: by 2002:a62:838d:0:b029:1ba:9b85:2eac with SMTP id h135-20020a62838d0000b02901ba9b852eacmr1917244pfe.36.1612483492832; Thu, 04 Feb 2021 16:04:52 -0800 (PST) MIME-Version: 1.0 References: <20210115210616.404156-1-ndesaulniers@google.com> <7354583d-de40-b6b9-6534-a4f4c038230f@fb.com> <12b6c2ca-4cf7-4edd-faf2-72e3cb59c00e@fb.com> <20210117201500.GO457607@kernel.org> In-Reply-To: From: Nick Desaulniers Date: Thu, 4 Feb 2021 16:04:40 -0800 Message-ID: Subject: Re: [PATCH v5 0/3] Kbuild: DWARF v5 support To: Andrii Nakryiko Cc: Arnaldo Carvalho de Melo , Yonghong Song , Andrii Nakryiko , Jiri Olsa , Sedat Dilek , Nathan Chancellor , Clang-Built-Linux ML , Fangrui Song , bpf Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Moving a bunch of folks + lists to BCC. On Thu, Feb 4, 2021 at 3:54 PM Andrii Nakryiko wrote: > > On Wed, Feb 3, 2021 at 7:13 PM Nick Desaulniers wrote: > > > > On Wed, Feb 3, 2021 at 6:58 PM Andrii Nakryiko > > wrote: > > > > > > On Wed, Feb 3, 2021 at 5:31 PM Nick Desaulniers wrote: > > > > > > > > On Sun, Jan 17, 2021 at 12:14 PM Arnaldo Carvalho de Melo > > > > wrote: > > > > > > > > > > Em Fri, Jan 15, 2021 at 03:43:06PM -0800, Yonghong Song escreveu: > > > > > > > > > > > > > > > > > > On 1/15/21 3:34 PM, Nick Desaulniers wrote: > > > > > > > On Fri, Jan 15, 2021 at 3:24 PM Yonghong Song wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 1/15/21 1:53 PM, Sedat Dilek wrote: > > > > > > > > > En plus, I encountered breakage with GCC v10.2.1 and LLVM=1 and > > > > > > > > > CONFIG_DEBUG_INFO_DWARF4. > > > > > > > > > So might be good to add a "depends on !DEBUG_INFO_BTF" in this combination. > > > > > > > > > > > > > > Can you privately send me your configs that repro? Maybe I can isolate > > > > > > > it to a set of configs? > > > > > > > > > > > > > > > > > > > > > > > I suggested not to add !DEBUG_INFO_BTF to CONFIG_DEBUG_INFO_DWARF4. > > > > > > > > It is not there before and adding this may suddenly break some users. > > > > > > > > > > > > > > > > If certain combination of gcc/llvm does not work for > > > > > > > > CONFIG_DEBUG_INFO_DWARF4 with pahole, this is a bug bpf community > > > > > > > > should fix. > > > > > > > > > > > > > > Is there a place I should report bugs? > > > > > > > > > > > > You can send bug report to Arnaldo Carvalho de Melo , > > > > > > dwarves@vger.kernel.org and bpf@vger.kernel.org. > > > > > > > > > > I'm coming back from vacation, will try to read the messages and see if > > > > > I can fix this. > > > > > > > > IDK about DWARF v4; that seems to work for me. I was previously observing > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1922698 > > > > with DWARF v5. I just re-pulled the latest pahole, rebuilt, and no > > > > longer see that warning. > > > > > > > > I now observe a different set. I plan on attending "BPF office hours > > > > tomorrow morning," but if anyone wants a sneak peak of the errors and > > > > how to reproduce: > > > > https://gist.github.com/nickdesaulniers/ae8c9efbe4da69b1cf0dce138c1d2781 > > > > > > > > > > Is there another (easy) way to get your patch set without the b4 tool? > > > Is your patch set present in some patchworks instance, so that I can > > > download it in mbox format, for example? > > > > $ wget https://lore.kernel.org/lkml/20210130004401.2528717-2-ndesaulniers@google.com/raw > > -O - | git am > > $ wget https://lore.kernel.org/lkml/20210130004401.2528717-3-ndesaulniers@google.com/raw > > -O - | git am > > > > If you haven't tried b4 yet, it's quite nice. Hard to go back. Lore > > also has mbox.gz links. Not sure about patchwork. > > > > Ok, I managed to apply that on linux-next, but I can't get past this: > > ld.lld: error: undefined symbol: pa_trampoline_start > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header) Thanks for testing and the report. Do you have a .config you can send me to reproduce? > > ld.lld: error: undefined symbol: pa_trampoline_header > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header) > > ld.lld: error: undefined symbol: pa_trampoline_pgd > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header) > >>> referenced by trampoline_64.S:142 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:142) > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32) > > ld.lld: error: undefined symbol: pa_wakeup_start > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header) > > ld.lld: error: undefined symbol: pa_wakeup_header > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header) > > ld.lld: error: undefined symbol: pa_machine_real_restart_asm > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header) > > ld.lld: error: undefined symbol: pa_startup_32 > >>> referenced by trampoline_64.S:77 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:77) > >>> arch/x86/realmode/rm/trampoline_64.o:(trampoline_start) > > ld.lld: error: undefined symbol: pa_tr_flags > >>> referenced by trampoline_64.S:124 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:124) > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32) > > ld.lld: error: undefined symbol: pa_tr_cr4 > >>> referenced by trampoline_64.S:138 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:138) > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32) > > ld.lld: error: undefined symbol: pa_tr_efer > >>> referenced by trampoline_64.S:146 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:146) > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32) > >>> referenced by trampoline_64.S:147 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:147) > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32) > > ld.lld: error: undefined symbol: pa_startup_64 > >>> referenced by trampoline_64.S:161 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:161) > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32) > > ld.lld: error: undefined symbol: pa_tr_gdt > >>> referenced by arch/x86/realmode/rm/trampoline_64.o:(tr_gdt) > >>> referenced by reboot.S:28 (/data/users/andriin/linux/arch/x86/realmode/rm/reboot.S:28) > >>> arch/x86/realmode/rm/reboot.o:(machine_real_restart_asm) > > ld.lld: error: undefined symbol: pa_machine_real_restart_paging_off > >>> referenced by reboot.S:34 (/data/users/andriin/linux/arch/x86/realmode/rm/reboot.S:34) > >>> arch/x86/realmode/rm/reboot.o:(machine_real_restart_asm) > > ld.lld: error: undefined symbol: pa_machine_real_restart_idt > >>> referenced by reboot.S:47 (/data/users/andriin/linux/arch/x86/realmode/rm/reboot.S:47) > >>> arch/x86/realmode/rm/reboot.o:(machine_real_restart_asm) > > ld.lld: error: undefined symbol: pa_machine_real_restart_gdt > >>> referenced by reboot.S:54 (/data/users/andriin/linux/arch/x86/realmode/rm/reboot.S:54) > >>> arch/x86/realmode/rm/reboot.o:(machine_real_restart_asm) > >>> referenced by arch/x86/realmode/rm/reboot.o:(machine_real_restart_gdt) > > ld.lld: error: undefined symbol: pa_wakeup_gdt > >>> referenced by arch/x86/realmode/rm/wakeup_asm.o:(wakeup_gdt) > CC arch/x86/mm/numa_64.o > CC arch/x86/mm/amdtopology.o > HOSTCC arch/x86/entry/vdso/vdso2c > make[4]: *** [arch/x86/realmode/rm/realmode.elf] Error 1 > make[3]: *** [arch/x86/realmode/rm/realmode.bin] Error 2 > make[2]: *** [arch/x86/realmode] Error 2 > make[2]: *** Waiting for unfinished jobs.... > > > Hopefully Arnaldo will have better luck. > > > > > > > > > > > > > > (FWIW: some other folks are hitting issues now with kernel's lack of > > > > DWARF v5 support: https://bugzilla.redhat.com/show_bug.cgi?id=1922707) > > > > > > -- > > Thanks, > > ~Nick Desaulniers -- Thanks, ~Nick Desaulniers