From: Nick Desaulniers <ndesaulniers@google.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Yonghong Song <yhs@fb.com>, bpf <bpf@vger.kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Kernel Team <kernel-team@fb.com>,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH bpf-next v3 1/5] selftests: set CC to clang in lib.mk if LLVM is set
Date: Tue, 13 Apr 2021 15:13:19 -0700 [thread overview]
Message-ID: <CAKwvOdnJYbBs=F2yZLqKvZX5_iHv_X_zCfQXSS3sv=iVDejL=w@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzZM3bLp=zFJ99ZX6iyM1D5gfB6eyweurVjn6iVOLdsrow@mail.gmail.com>
On Tue, Apr 13, 2021 at 3:05 PM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Tue, Apr 13, 2021 at 8:34 AM Yonghong Song <yhs@fb.com> wrote:
> >
> > selftests/bpf/Makefile includes lib.mk. With the following command
> > make -j60 LLVM=1 LLVM_IAS=1 <=== compile kernel
> > make -j60 -C tools/testing/selftests/bpf LLVM=1 LLVM_IAS=1 V=1
> > some files are still compiled with gcc. This patch
> > fixed lib.mk issue which sets CC to gcc in all cases.
> >
> > Cc: Sedat Dilek <sedat.dilek@gmail.com>
> > Signed-off-by: Yonghong Song <yhs@fb.com>
> > ---
> > tools/testing/selftests/lib.mk | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> > index a5ce26d548e4..9a41d8bb9ff1 100644
> > --- a/tools/testing/selftests/lib.mk
> > +++ b/tools/testing/selftests/lib.mk
> > @@ -1,6 +1,10 @@
> > # This mimics the top-level Makefile. We do it explicitly here so that this
> > # Makefile can operate with or without the kbuild infrastructure.
> > +ifneq ($(LLVM),)
> > +CC := clang
>
> Does this mean that cross-compilation with Clang doesn't work at all
> or is achieved in some other way?
Right, this probably doesn't support cross compilation w/ Clang.
Rather than invoke `$(CROSS_COMPILE) clang`, you'd do `clang
--target=$(CROSS_COMPILE)`. Even then, cross linking executables is
hairy. But at least this should enable native compilation, which is a
start.
>
>
> > +else
> > CC := $(CROSS_COMPILE)gcc
> > +endif
> >
> > ifeq (0,$(MAKELEVEL))
> > ifeq ($(OUTPUT),)
> > --
> > 2.30.2
> >
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2021-04-13 22:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 15:34 [PATCH bpf-next v3 0/5] bpf: tools: support build selftests/bpf with clang Yonghong Song
2021-04-13 15:34 ` [PATCH bpf-next v3 1/5] selftests: set CC to clang in lib.mk if LLVM is set Yonghong Song
2021-04-13 22:04 ` Andrii Nakryiko
2021-04-13 22:13 ` Nick Desaulniers [this message]
2021-04-13 22:27 ` Yonghong Song
2021-04-13 22:34 ` Nick Desaulniers
2021-04-13 23:22 ` Andrii Nakryiko
2021-04-13 15:34 ` [PATCH bpf-next v3 2/5] tools: allow proper CC/CXX/... override with LLVM=1 in Makefile.include Yonghong Song
2021-04-13 15:34 ` [PATCH bpf-next v3 3/5] selftests/bpf: fix test_cpp compilation failure with clang Yonghong Song
2021-04-13 22:05 ` Andrii Nakryiko
2021-04-13 15:34 ` [PATCH bpf-next v3 4/5] selftests/bpf: silence clang compilation warnings Yonghong Song
2021-04-13 22:07 ` Andrii Nakryiko
2021-04-13 22:17 ` Nick Desaulniers
2021-04-13 22:37 ` Yonghong Song
2021-04-13 15:34 ` [PATCH bpf-next v3 5/5] bpftool: fix a clang compilation warning Yonghong Song
2021-04-13 19:36 ` [PATCH bpf-next v3 0/5] bpf: tools: support build selftests/bpf with clang Martin KaFai Lau
2021-04-16 0:21 ` Alexei Starovoitov
2021-04-16 3:59 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdnJYbBs=F2yZLqKvZX5_iHv_X_zCfQXSS3sv=iVDejL=w@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=sedat.dilek@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).