From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09677C433E6 for ; Tue, 9 Mar 2021 18:55:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B05FC6523B for ; Tue, 9 Mar 2021 18:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbhCISy1 (ORCPT ); Tue, 9 Mar 2021 13:54:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbhCISyU (ORCPT ); Tue, 9 Mar 2021 13:54:20 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9A3EC06174A; Tue, 9 Mar 2021 10:54:19 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id e20so3019874ljn.6; Tue, 09 Mar 2021 10:54:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xh3ApoclD7V/WByGDpuR9C/OkQWfw3kJt316u4qe2Ls=; b=MWCkLT/CyytKUTWPdRnUOmx8fTSjAV4lMSAVCKtnFMZI76r8mKFY/BUCioBvi5tc6J tY74k59BHl00aHRU6aSYCsa2OlqknL0uQYqBN0AkWcy49vQHdJh1Y5r/oWpKDcu+Vvf2 nkmEMGL9qXTarSbsvpXy9AfY/Ak+4ZmbJp+HsUSB78B0udj0qa/VuXBQ2j4syLpwuFpE vaMnvoSyQUi1VA+ACHTBiLWZypI9sIYSVFkVbfVKZoaLlQoI8H2NSIkJfykkNZ7OZYPy 3ejhOXGRNU5tkGEz3hd2iWNW+es2biPvkkTSVaWhSOYnq3yHcAfw6CWqZfH9pPoaKkyC jSEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xh3ApoclD7V/WByGDpuR9C/OkQWfw3kJt316u4qe2Ls=; b=iBrV5IZeHejLh/scIBdvOThk7JAWT0TChEyGsncfHcRU7sNgja+xYQ5w//QT7KAYcJ iD/vTooG2cksMJSIR9BftIshIsRZ1fLosFBOxCgyt7PskFpxfhGOpmzry//uDE4d7Xt1 jndXu657IvIBljJ1pASEZpHZQsKAdJDnyQPXLN9S50c8s1UrM2C81E5vlgSSooI5SUBx m0LCYpkhjFMvt4n8hAueXfz79eH6JtTSMpFLqHIdR42BxoiyvKLudtLu+MSs23r89G+a SwCswjieREtgTdxxViypabhaEBPuiuntoGhGggYwERre5Doht9n0u4AfOHH05z0OWwHH 1yNg== X-Gm-Message-State: AOAM5313uZHI56GgY5gIHPWEujdvKY4fZ7hmBVShGBkF9ZH2+BzjgFuK c9CDKx8ErcXb4E9iK4+jFlTxqK+Idy22BFX3pGk= X-Google-Smtp-Source: ABdhPJyZRJwOUo9O0ktr4pYaRSqcRY5bi84dZTY2/rxSJvBDjNhanwh9dLd36LaF+9DO0wUVZUzdQN0o3gNbsp48cas= X-Received: by 2002:a2e:8193:: with SMTP id e19mr14260345ljg.445.1615316058308; Tue, 09 Mar 2021 10:54:18 -0800 (PST) MIME-Version: 1.0 References: <20210309032214.2112438-1-liuhangbin@gmail.com> In-Reply-To: <20210309032214.2112438-1-liuhangbin@gmail.com> From: William Tu Date: Tue, 9 Mar 2021 10:53:41 -0800 Message-ID: Subject: Re: [PATCH net] selftests/bpf: set gopt opt_class to 0 if get tunnel opt failed To: Hangbin Liu Cc: Linux Kernel Network Developers , Jakub Kicinski , Daniel Borkmann , Yi-Hung Wei , David Miller , bpf Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Mar 8, 2021 at 7:22 PM Hangbin Liu wrote: > > When fixing the bpf test_tunnel.sh genve failure. I only fixed > the IPv4 part but forgot the IPv6 issue. Similar with the IPv4 > fixes 557c223b643a ("selftests/bpf: No need to drop the packet when > there is no geneve opt"), when there is no tunnel option and > bpf_skb_get_tunnel_opt() returns error, there is no need to drop the > packets and break all geneve rx traffic. Just set opt_class to 0 and > keep returning TC_ACT_OK at the end. > > Fixes: 933a741e3b82 ("selftests/bpf: bpf tunnel test.") > Signed-off-by: Hangbin Liu > --- LGTM, thanks. Acked-by: William Tu