From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6CBFC76196 for ; Tue, 28 Mar 2023 13:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbjC1NY6 (ORCPT ); Tue, 28 Mar 2023 09:24:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232868AbjC1NYz (ORCPT ); Tue, 28 Mar 2023 09:24:55 -0400 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAD87BBAE for ; Tue, 28 Mar 2023 06:24:48 -0700 (PDT) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-5445009c26bso229165227b3.8 for ; Tue, 28 Mar 2023 06:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680009888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ntULfQJggmdaqbZLqK7ncFbPSNSEXt5TzQS/aFU/5Pc=; b=iLIlR3VysUqN2n+K7Rz9WKfCcJLSTSx4NXO9I1yXLrlfhLgH5+IkJOW/OExv+tAp2p KLwmq425It8H20dpM0ac09a+vLFQBsaodZP50nnSdn4NPSgU/FnP4IoWbe2linipSeqz gXPndO8BQ9boGvc7auVZsdo8oEo2nNNubeOewSk0lDqJmSYfpk9BL0NvDdeBZ/+eYbYt vCoep2rw0xDCxlAUelFlpn+OMs11ce2T2shwo+AdP9qIAH/gH8oGDJNKaJLz4JCsPJcy 3O/lx+x7RQmoTNPuwkKIytNaDqU/QTxCL4tT2Daz/Dep3lWyEoL5WhB/cC0yuxcgmIG1 Cdkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680009888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ntULfQJggmdaqbZLqK7ncFbPSNSEXt5TzQS/aFU/5Pc=; b=gFAAMbfJ+1/QUG2hvcOhb+YIkENz+7gcflaZ95ZlXxi6McLOqNyKYKHbU6Sq383Mh5 MudqZQA2HDGLU9wUFIvxAhGF0pIB7WAsIoRAE0J1eA3lt0EBDG9j+2Xyuza/dkLxI5ZT zBTAaqyD5aRN4HlerA6R4fBtmUGfSoqQapERzgEIPm6CUYNTBAPiukJfWRgxXFK4CgQB QMQsW8Q0hXmKtbDeEQuupI7KJMwqrMoyOvC1L9FV1FNl1h1qiHq6T2pDFD6Caglo6ywC KCJE6t2RhEpwH8v5opeLunemrRs0VTOfhFL27bKGH9cRjTkfncDba/xVV4v5I1O81Os7 Zqfg== X-Gm-Message-State: AAQBX9ecXEpvFZLZyEV1F+AUeeyo4sg0HsI2G121BYNCkgxtCPuQSJ2P bAUpe+q9Zq1xFDsDMKAHzTgI1u+50ZoUFVpgz2QAng== X-Google-Smtp-Source: AKy350ZbQ5L3cvQeH+/uAiEzez0+L4i4KA3mwR2j+xMSO9YwlPgoHcvCiIw0v9a5U7lB87sYMPJen1Av3A82DPd1VBw= X-Received: by 2002:a81:af60:0:b0:544:b8c2:3cf4 with SMTP id x32-20020a81af60000000b00544b8c23cf4mr7307084ywj.1.1680009887781; Tue, 28 Mar 2023 06:24:47 -0700 (PDT) MIME-Version: 1.0 References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-2-yosryahmed@google.com> In-Reply-To: <20230328061638.203420-2-yosryahmed@google.com> From: Shakeel Butt Date: Tue, 28 Mar 2023 06:24:36 -0700 Message-ID: Subject: Re: [PATCH v1 1/9] cgroup: rename cgroup_rstat_flush_"irqsafe" to "atomic" To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Mar 27, 2023 at 11:16=E2=80=AFPM Yosry Ahmed wrote: > > cgroup_rstat_flush_irqsafe() can be a confusing name. It may read as > "irqs are disabled throughout", which is what the current implementation > does (currently under discussion [1]), but is not the intention. The > intention is that this function is safe to call from atomic contexts. > Name it as such. > > Suggested-by: Johannes Weiner > Signed-off-by: Yosry Ahmed Acked-by: Shakeel Butt