From: Johan Almbladh <johan.almbladh@anyfinetworks.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Paul Burton <paulburton@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
chenhuacai@kernel.org, jiaxun.yang@flygoat.com,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Tony Ambardar <tony.ambardar@gmail.com>,
bpf <bpf@vger.kernel.org>,
linux-mips@vger.kernel.org, Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/7] mips: uasm: Add workaround for Loongson-2F nop CPU errata
Date: Mon, 18 Oct 2021 14:17:51 +0200 [thread overview]
Message-ID: <CAM1=_QQqTSABUQ1WgmBS2mgRzYKB7UA7CHyDLfwnnFnEDL4QBw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2110181359111.31442@angie.orcam.me.uk>
You are right, it should say "at" here instead of "ax". The code uses
the MIPS "at" register. AX is a BPF register, so this is a typo in my
commit message.
Thanks,
Johan
On Mon, Oct 18, 2021 at 2:00 PM Maciej W. Rozycki <macro@orcam.me.uk> wrote:
>
> On Tue, 5 Oct 2021, Johan Almbladh wrote:
>
> > This patch implements a workaround for the Loongson-2F nop in generated,
> > code, if the existing option CONFIG_CPU_NOP_WORKAROUND is set. Before,
> > the binutils option -mfix-loongson2f-nop was enabled, but no workaround
> > was done when emitting MIPS code. Now, the nop pseudo instruction is
> > emitted as "or ax,ax,zero" instead of the default "sll zero,zero,0". This
>
> Confusing typo here, s/ax/at/.
>
> Maciej
next prev parent reply other threads:[~2021-10-18 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 16:54 [PATCH 0/7] A new eBPF JIT implementation for MIPS Johan Almbladh
2021-10-05 16:54 ` [PATCH 1/7] MIPS: uasm: Enable muhu opcode for MIPS R6 Johan Almbladh
2021-10-05 16:54 ` [PATCH 2/7] mips: uasm: Add workaround for Loongson-2F nop CPU errata Johan Almbladh
2021-10-05 17:59 ` Jiaxun Yang
2021-10-18 12:00 ` Maciej W. Rozycki
2021-10-18 12:17 ` Johan Almbladh [this message]
2021-10-05 16:54 ` [PATCH 3/7] mips: bpf: Add eBPF JIT for 32-bit MIPS Johan Almbladh
2021-10-05 16:54 ` [PATCH 4/7] mips: bpf: Add new eBPF JIT for 64-bit MIPS Johan Almbladh
2021-10-05 16:54 ` [PATCH 5/7] mips: bpf: Add JIT workarounds for CPU errata Johan Almbladh
2021-10-05 18:00 ` Jiaxun Yang
2022-01-07 9:25 ` Huang Pei
2022-01-07 10:17 ` Daniel Borkmann
2021-10-05 16:54 ` [PATCH 6/7] mips: bpf: Enable eBPF JITs Johan Almbladh
2021-10-06 14:10 ` [PATCH 0/7] A new eBPF JIT implementation for MIPS patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM1=_QQqTSABUQ1WgmBS2mgRzYKB7UA7CHyDLfwnnFnEDL4QBw@mail.gmail.com' \
--to=johan.almbladh@anyfinetworks.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chenhuacai@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jiaxun.yang@flygoat.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=netdev@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=songliubraving@fb.com \
--cc=tony.ambardar@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).