From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C0AC433FE for ; Fri, 4 Dec 2020 05:56:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C3A022581 for ; Fri, 4 Dec 2020 05:56:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725989AbgLDFzw (ORCPT ); Fri, 4 Dec 2020 00:55:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbgLDFzw (ORCPT ); Fri, 4 Dec 2020 00:55:52 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C9A8C061A51; Thu, 3 Dec 2020 21:55:12 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id f9so2361855pfc.11; Thu, 03 Dec 2020 21:55:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T/1OadALc5iFQns1WLD+456kpoRrFBtsFL8PSfXx560=; b=BoBr3TMOOwga/KailUe1iAIuMG5ZeAUavmsfKtjgmptC86o350fnDmw/s3XlHpdxma 5FS1ScfudXT0Iva55qu8VjGOYl1OEwBxtrAAB0TVHMu7xoklc/ykH/ZXpHJzZCS9/yrW Y/tq9eiQ96VuvGH6QVEalAPrGA5sh+n5iTKLmWMgVQXko2wwaQH0u4wwWaJanPOLZMmj G0eTGr622vY/z4euZG8Qs+rCZz21YN/ih8KXJbPT1PSoL1BCeDfIInOZ4a211Tg2S9a+ JAsBKGj0AiOAJw5LN6bVrnuSib7DIjU9v4rfiK2Tg1APrl4lcuDEB23LtIbJCo6CjXIu CwXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T/1OadALc5iFQns1WLD+456kpoRrFBtsFL8PSfXx560=; b=MqGxjPEkEft0PDB6lEXemM+v2HNWAYTeXOEqsJVq1DVIu78cR5tweN7frH/jfkzpDb 7tsokZ8c1COWWsMz4bHfZcf3goNjmdKdf+ZefDy/A/Z1HFMoQ05Mr1vbR6HU7U6EM0Bd s7k5ccHbBFYOEggH81Ff+B4zzLo+NmqrzVWOqNU2AmAu3Z4493Tr6AVXY0iGo/CM9VaM +CHRHZhe64tQYXIcdFvDI/iHPVRjDnCrNYv4KxSTAQXYUppDhTignNWIU8PsbESJcktn IIFds1o+k0d48niogWq05z1qnbcbTeO6K6YQRBD6izm/8R1IvTVn1XqXvILJMe5FeJxv l2sw== X-Gm-Message-State: AOAM5331bMirx+AVXTYUZ+F+9hzodJ80bUE56NsaTdiCy+TDZHj7Q62R kTcZCfaPCWC2jQ4LyKnIU+o+tJzbZVo+Yr+YpgQ= X-Google-Smtp-Source: ABdhPJyclIFcWOpFo7Ps3i5Z6EWQuF1HxQtyzTR8HiVyfdeQZDB9AqwbfYLsNF42CrwRQ2wgUshpFRq7HeRU1FW6FfE= X-Received: by 2002:aa7:93a7:0:b029:19d:89a6:eb13 with SMTP id x7-20020aa793a70000b029019d89a6eb13mr2428998pff.10.1607061312046; Thu, 03 Dec 2020 21:55:12 -0800 (PST) MIME-Version: 1.0 References: <20201201194438.37402-1-xiyou.wangcong@gmail.com> <20201202171032.029b1cd8@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: From: Cong Wang Date: Thu, 3 Dec 2020 21:55:00 -0800 Message-ID: Subject: Re: [Patch net] lwt: disable BH too in run_lwt_bpf() To: Alexei Starovoitov Cc: Jakub Kicinski , Linux Kernel Network Developers , Dongdong Wang , Thomas Graf , bpf , Cong Wang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Dec 3, 2020 at 10:30 AM Alexei Starovoitov wrote: > > On Thu, Dec 3, 2020 at 10:28 AM Cong Wang wrote: > > > > On Thu, Dec 3, 2020 at 10:22 AM Alexei Starovoitov > > wrote: > > > > > > I guess my previous comment could be misinterpreted. > > > Cong, > > > please respin with changing preempt_disable to migrate_disable > > > and adding local_bh_disable. > > > > I have no objection, just want to point out migrate_disable() may > > not exist if we backport this further to -stable, this helper was > > introduced in Feb 2020. > > I see. Then please split it into two patches for ease of backporting. You mean the first patch does the same as this patch and the second patch replaces preempt_disable() with migrate_disable(). Right? Thanks.