bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
Subject: Re: [Crash] unhandled kernel memory read from unreadable memory
Date: Sat, 13 Jun 2020 10:52:08 -0700	[thread overview]
Message-ID: <CAM_iQpUNNs4fzLAT8xmhbg+dhM0gdS+HVOtFD+fMJegeSHgUFA@mail.gmail.com> (raw)
In-Reply-To: <CAMdYzYpKEOWCjb-kZj=HAkzQ0_QNs4N_6pXz1qPb1YQ2Xh5Jsg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]


On Sat, Jun 13, 2020 at 5:41 AM Peter Geis <pgwipeout@gmail.com> wrote:
> Good Morning,
> Last night I started experiencing crashes on my home server.
> I updated to 5.6.17 from 5.6.15 a few days ago but I'm not sure if
> that is related.
> The crash occurred four times between last night and this morning.

Yeah, this is known. Can you test the attached patch?


[-- Attachment #2: cgroup_sk_alloc.diff --]
[-- Type: text/x-patch, Size: 614 bytes --]

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 6c9c6ac83936..c01245a19ea2 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -6438,9 +6438,6 @@ void cgroup_sk_alloc_disable(void)
 void cgroup_sk_alloc(struct sock_cgroup_data *skcd)
-	if (cgroup_sk_alloc_disabled)
-		return;
 	/* Socket clone path */
 	if (skcd->val) {
@@ -6453,6 +6450,9 @@ void cgroup_sk_alloc(struct sock_cgroup_data *skcd)
+	if (cgroup_sk_alloc_disabled)
+		return;
 	/* Don't associate the sock with unrelated interrupted task's cgroup. */
 	if (in_interrupt())

      reply	other threads:[~2020-06-13 17:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-13 12:39 [Crash] unhandled kernel memory read from unreadable memory Peter Geis
2020-06-13 17:52 ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpUNNs4fzLAT8xmhbg+dhM0gdS+HVOtFD+fMJegeSHgUFA@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=pgwipeout@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).