bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Alexander Lobakin <alobakin@pm.me>
Cc: bpf <bpf@vger.kernel.org>,
	duanxiongchun@bytedance.com,
	Dongdong Wang <wangdongdong.6@bytedance.com>,
	Jiang Wang <jiang.wang@bytedance.com>,
	Cong Wang <cong.wang@bytedance.com>,
	John Fastabend <john.fastabend@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jakub Sitnicki <jakub@cloudflare.com>,
	Lorenz Bauer <lmb@cloudflare.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [Patch bpf-next v5 06/11] sock: introduce sk->sk_prot->psock_update_sk_prot()
Date: Thu, 18 Mar 2021 09:40:40 -0700	[thread overview]
Message-ID: <CAM_iQpVYqcYCA97KTx6bRAEkkO4gpy_t8YCGTUQ2XRDnJ=-sFw@mail.gmail.com> (raw)
In-Reply-To: <20210318120930.5723-1-alobakin@pm.me>

On Thu, Mar 18, 2021 at 5:09 AM Alexander Lobakin <alobakin@pm.me> wrote:
> Regarding that both {tcp,udp}_bpf_update_proto() is global and
> for now they are the only two implemented callbacks, wouldn't it
> be worthy to straighten the calls here? Like
>
>         return INDIRECT_CALL_2(sk->sk_prot->psock_update_sk_prot,
>                                tcp_bpf_update_proto,
>                                udp_bpf_update_proto,
>                                sk, false);

I get your point, but AF_UNIX will implement this in the next patchset,
and my colleague is working on vsock support too, so it will go beyond
INET very soon.

>
> (the same in sk_psock_restore_proto() then)
>
> Or this code path is not performance-critical?

It is not on the hot path, updating proto happens when we insert
the socket to the map or remove it from there.

Thanks.

  reply	other threads:[~2021-03-18 16:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17  2:22 [Patch bpf-next v5 00/11] sockmap: introduce BPF_SK_SKB_VERDICT and support UDP Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 01/11] skmsg: lock ingress_skb when purging Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 02/11] skmsg: introduce a spinlock to protect ingress_msg Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 03/11] skmsg: introduce skb_send_sock() for sock_map Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 04/11] skmsg: avoid lock_sock() in sk_psock_backlog() Cong Wang
2021-03-20  2:45   ` John Fastabend
2021-03-22  3:23     ` Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 05/11] sock_map: introduce BPF_SK_SKB_VERDICT Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 06/11] sock: introduce sk->sk_prot->psock_update_sk_prot() Cong Wang
2021-03-18 12:09   ` Alexander Lobakin
2021-03-18 16:40     ` Cong Wang [this message]
2021-03-17  2:22 ` [Patch bpf-next v5 07/11] udp: implement ->read_sock() for sockmap Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 08/11] skmsg: extract __tcp_bpf_recvmsg() and tcp_bpf_wait_data() Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 09/11] udp: implement udp_bpf_recvmsg() for sockmap Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 10/11] sock_map: update sock type checks for UDP Cong Wang
2021-03-17  2:22 ` [Patch bpf-next v5 11/11] selftests/bpf: add a test case for udp sockmap Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpVYqcYCA97KTx6bRAEkkO4gpy_t8YCGTUQ2XRDnJ=-sFw@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=alobakin@pm.me \
    --cc=bpf@vger.kernel.org \
    --cc=cong.wang@bytedance.com \
    --cc=daniel@iogearbox.net \
    --cc=duanxiongchun@bytedance.com \
    --cc=jakub@cloudflare.com \
    --cc=jiang.wang@bytedance.com \
    --cc=john.fastabend@gmail.com \
    --cc=lmb@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=wangdongdong.6@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).