bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "sunyucong@gmail.com" <sunyucong@gmail.com>,
	Jiang Wang <jiang.wang@bytedance.com>,
	Cong Wang <cong.wang@bytedance.com>,
	Yucong Sun <fallentree@fb.com>,
	Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: reduce more flakyness in sockmap_listen
Date: Tue, 31 Aug 2021 12:33:13 -0700	[thread overview]
Message-ID: <CAM_iQpVw-5dG8Na9e851bQy2_BcpZQ5QK+r554NZsP0_dbzwNw@mail.gmail.com> (raw)
In-Reply-To: <CAADnVQJB3GKKr1hMWHNKYhoo8CzrDQ83LEnO8c+ntOBtEkjApA@mail.gmail.com>

On Thu, Aug 26, 2021 at 12:08 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Thu, Aug 26, 2021 at 11:18 AM sunyucong@gmail.com
> <sunyucong@gmail.com> wrote:
> >
> > Reporting back: I tried a select() based approach, (as attached below)
> >  but unfortunately it doesn't seem to work. During testing,  I am
> > always getting full timeout errors as the socket never seems to become
> > ready to read(). My guess is that this has something to do with the
> > sockets being created through sockpair() , but I am unable to confirm.
> >
> > On the other hand, the previous patch approach works perfectly fine, I
> > would still like to request to apply that instead.
>
> Ok. Applied your earlier patch, but it's a short term workaround.
> select() should work for af_unix.
> I suspect something got broken with the redirect.
> Cong, Jiang,
> could you please take a look ?

Like I mentioned before, I suspect there is some delay in one of
the queues on the way or there is a worker wakeup latency.
I will try adding some tracepoints to see if I can capture it.

Thanks.

  parent reply	other threads:[~2021-08-31 19:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 18:47 [PATCH bpf-next] selftests/bpf: reduce more flakyness in sockmap_listen Yucong Sun
2021-08-26  1:04 ` Alexei Starovoitov
2021-08-26  2:37   ` sunyucong
2021-08-26 18:18     ` sunyucong
2021-08-26 19:07       ` Alexei Starovoitov
2021-08-26 19:23         ` sunyucong
2021-08-26 21:05           ` Alexei Starovoitov
2021-08-26 21:07             ` sunyucong
2021-08-31 19:33         ` Cong Wang [this message]
2021-09-02  1:33           ` Cong Wang
2021-09-02  3:34             ` sunyucong
2021-09-03 23:44               ` Cong Wang
2021-09-07  2:24                 ` sunyucong
2021-09-15 14:13                   ` sunyucong
2021-09-15 16:54                   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpVw-5dG8Na9e851bQy2_BcpZQ5QK+r554NZsP0_dbzwNw@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=cong.wang@bytedance.com \
    --cc=fallentree@fb.com \
    --cc=jiang.wang@bytedance.com \
    --cc=sunyucong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).