From: Yaniv Agman <yanivagman@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
Yonghong Song <yhs@fb.com>
Subject: Re: libbpf error: unknown register name 'r0' in asm
Date: Fri, 9 Oct 2020 22:32:16 +0300 [thread overview]
Message-ID: <CAMy7=ZWhAzJP5m3QW0gHe4rVFoETT=zhCcyVeKBuTcO=ttC=MA@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzYJQ_RZgy8YCPxfF+QEkx9W+jeu-3O3CX+vEqTFtOT2Fw@mail.gmail.com>
בתאריך יום ו׳, 9 באוק׳ 2020 ב-21:39 מאת Andrii Nakryiko
<andrii.nakryiko@gmail.com>:
>
> On Fri, Oct 9, 2020 at 11:33 AM Yaniv Agman <yanivagman@gmail.com> wrote:
> >
> > בתאריך יום ו׳, 9 באוק׳ 2020 ב-21:21 מאת Daniel Borkmann
> > <daniel@iogearbox.net>:
> > >
> > > On 10/9/20 8:09 PM, Yaniv Agman wrote:
> > > > בתאריך יום ו׳, 9 באוק׳ 2020 ב-20:39 מאת Daniel Borkmann
> > > > <daniel@iogearbox.net>:
> > > >>
> > > >> On 10/9/20 6:56 PM, Yaniv Agman wrote:
> > > >>> בתאריך יום ו׳, 9 באוק׳ 2020 ב-19:27 מאת Daniel Borkmann
> > > >>> <daniel@iogearbox.net>:
> > > >>>>
> > > >>>> [ Cc +Yonghong ]
> > > >>>>
> > > >>>> On 10/9/20 6:05 PM, Yaniv Agman wrote:
> > > >>>>> Pulling the latest changes of libbpf and compiling my application with it,
> > > >>>>> I see the following error:
> > > >>>>>
> > > >>>>> ../libbpf/src//root/usr/include/bpf/bpf_helpers.h:99:10: error:
> > > >>>>> unknown register name 'r0' in asm
> > > >>>>> : "r0", "r1", "r2", "r3", "r4", "r5");
> > > >>>>>
> > > >>>>> The commit which introduced this change is:
> > > >>>>> 80c7838600d39891f274e2f7508b95a75e4227c1
> > > >>>>>
> > > >>>>> I'm not sure if I'm doing something wrong (missing include?), or this
> > > >>>>> is a genuine error
> > > >>>>
> > > >>>> Seems like your clang/llvm version might be too old.
> > > >>>
> > > >>> I'm using clang 10.0.1
> > > >>
> > > >> Ah, okay, I see. Would this diff do the trick for you?
> > > >
> > > > Yes! Now it compiles without any problems!
> > >
> > > Great, thx, I'll cook proper fix and check with clang6 as Yonghong mentioned.
> > >
> >
> > Thanks!
> > Does this happen because I'm first compiling using "emit-llvm" and
> > then using llc?
>
> So this must be the reason, but I'll wait for Yonghong to confirm.
>
> > I wish I could use bpf target directly, but I'm then having problems
> > with includes of asm code (like pt_regs and other stuff)
>
> Are you developing for a 32-bit platform? Or what exactly is the
> problem? I've been trying to solve problems for 32-bit arches recently
> by making libbpf smarter, that relies on CO-RE though. Is CO-RE an
> option for you?
>
Examples for the errors I'm getting:
/lib/modules/4.14.199-1-MANJARO/build/arch/x86/include/asm/atomic.h:177:9:
error: invalid output constraint '+q' in asm
return xadd(&v->counter, i);
^
/lib/modules/4.14.199-1-MANJARO/build/arch/x86/include/asm/cmpxchg.h:234:25:
note: expanded from macro 'xadd'
#define xadd(ptr, inc) __xadd((ptr), (inc), LOCK_PREFIX)
...
From What I understood, this is a known issue for tracing programs
(like the one I'm developing)
Unfortunately, CO-RE is not (yet) an option.
I'm currently making the move from bcc to libbpf, and our application
needs to support kernel 4.14, and work on all environments.
> [...]
next prev parent reply other threads:[~2020-10-09 19:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 16:05 libbpf error: unknown register name 'r0' in asm Yaniv Agman
2020-10-09 16:27 ` Daniel Borkmann
2020-10-09 16:56 ` Yaniv Agman
2020-10-09 17:39 ` Daniel Borkmann
2020-10-09 18:09 ` Yaniv Agman
2020-10-09 18:21 ` Daniel Borkmann
2020-10-09 18:33 ` Yaniv Agman
2020-10-09 18:39 ` Andrii Nakryiko
2020-10-09 19:32 ` Yaniv Agman [this message]
2020-10-09 19:53 ` Andrii Nakryiko
2020-10-09 20:24 ` Yaniv Agman
2020-10-12 20:03 ` Andrii Nakryiko
2020-10-12 21:48 ` Yaniv Agman
2020-10-12 22:16 ` Andrii Nakryiko
2020-10-09 18:35 ` Andrii Nakryiko
2020-10-09 18:41 ` Daniel Borkmann
2020-10-09 18:59 ` Andrii Nakryiko
2020-10-09 19:08 ` Yonghong Song
2020-10-09 19:33 ` Yaniv Agman
2020-10-09 19:58 ` Daniel Borkmann
2020-10-21 9:43 ` Yaniv Agman
2020-10-21 17:18 ` Daniel Borkmann
2020-10-21 19:33 ` Yaniv Agman
2020-10-09 17:41 ` Yonghong Song
2020-10-09 18:03 ` Andrii Nakryiko
2020-10-09 18:12 ` Yaniv Agman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMy7=ZWhAzJP5m3QW0gHe4rVFoETT=zhCcyVeKBuTcO=ttC=MA@mail.gmail.com' \
--to=yanivagman@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).