From: Gilad Reti <gilad.reti@gmail.com>
To: KP Singh <kpsingh@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
linux-kselftest@vger.kernel.org,
Networking <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] selftests/bpf: add verifier test for PTR_TO_MEM spill
Date: Tue, 12 Jan 2021 18:24:10 +0200 [thread overview]
Message-ID: <CANaYP3E1o+0+ZXv_VnGZrK00nJ7WgEZs-HXZoYif4HpR7eF+Mg@mail.gmail.com> (raw)
In-Reply-To: <CACYkzJ7dK62zbn_z0S=-Xps1=DCEcd1FPYFon-BUeha=N5KnJQ@mail.gmail.com>
On Tue, Jan 12, 2021 at 6:17 PM KP Singh <kpsingh@kernel.org> wrote:
>
> On Tue, Jan 12, 2021 at 4:43 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
> >
> > On 1/12/21 4:35 PM, Gilad Reti wrote:
> > > On Tue, Jan 12, 2021 at 4:56 PM KP Singh <kpsingh@kernel.org> wrote:
> > >> On Tue, Jan 12, 2021 at 10:16 AM Gilad Reti <gilad.reti@gmail.com> wrote:
> > >>>
> > >>> Add test to check that the verifier is able to recognize spilling of
> > >>> PTR_TO_MEM registers.
> > >>
> > >> It would be nice to have some explanation of what the test does to
> > >> recognize the spilling of the PTR_TO_MEM registers in the commit
> > >> log as well.
> > >>
> > >> Would it be possible to augment an existing test_progs
> > >> program like tools/testing/selftests/bpf/progs/test_ringbuf.c to test
> > >> this functionality?
> >
> > How would you guarantee that LLVM generates the spill/fill, via inline asm?
>
> Yeah, I guess there is no sure-shot way to do it and, adding inline asm would
> just be doing the same thing as this verifier test. You can ignore me
> on this one :)
>
> It would, however, be nice to have a better description about what the test is
> actually doing./
>
>
I will re-submit the patch tomorrow. Thank you all for your patience.
> >
> > > It may be possible, but from what I understood from Daniel's comment here
> > >
> > > https://lore.kernel.org/bpf/17629073-4fab-a922-ecc3-25b019960f44@iogearbox.net/
> > >
> > > the test should be a part of the verifier tests (which is reasonable
> > > to me since it is
> > > a verifier bugfix)
> >
> > Yeah, the test_verifier case as you have is definitely the most straight
> > forward way to add coverage in this case.
next prev parent reply other threads:[~2021-01-12 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 9:15 [PATCH 2/2] selftests/bpf: add verifier test for PTR_TO_MEM spill Gilad Reti
2021-01-12 14:55 ` KP Singh
2021-01-12 15:35 ` Gilad Reti
2021-01-12 15:43 ` Daniel Borkmann
2021-01-12 16:17 ` KP Singh
2021-01-12 16:24 ` Gilad Reti [this message]
2021-01-12 16:59 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANaYP3E1o+0+ZXv_VnGZrK00nJ7WgEZs-HXZoYif4HpR7eF+Mg@mail.gmail.com \
--to=gilad.reti@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).