From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3504CC433FF for ; Tue, 13 Aug 2019 12:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 065E52067D for ; Tue, 13 Aug 2019 12:36:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lrApJRtm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728004AbfHMMgT (ORCPT ); Tue, 13 Aug 2019 08:36:19 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:42688 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726453AbfHMMgT (ORCPT ); Tue, 13 Aug 2019 08:36:19 -0400 Received: by mail-lj1-f193.google.com with SMTP id 15so9619515ljr.9; Tue, 13 Aug 2019 05:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/4zbvSpEn2DpmCJ6tMtDBdGBohm95LMSJu2Rb3mH21k=; b=lrApJRtm6GOhWs3fCFPJSlcSNogP0GznPdE24vcG3Z/F5ysBIyHK4jr3TmLyVAenyu h+reeHqoCtu5DnUOonZfy2rp0wqpy0QvIWd1egLjw9T+fHOo9bX4D5YJplkiBANlzg+Z YxoJvdWuGbwSks5nTFsOOCwSZvZqkTUwflPOvOlwIZSX4gGr1CPhFztABch0yEq1LGEz niMncc0gUHJSPmGlCnp7eYd+vKKI1m13mmcPqKSQd33YlT2b2H8DFXOYUkcC6lFgsZvv RCcC5ce0ZlXrJuUsDAAaXHftEs3Uc66lwJtN2oFXfWLTEOEySRPJVNo9EtMHQqBQljfF I95w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/4zbvSpEn2DpmCJ6tMtDBdGBohm95LMSJu2Rb3mH21k=; b=ombUIQlKZI4sna0UtPXjiTZdDEAjW09UgskoowRxZu6uQxgnjy0Or9pBdvwUOHwk5C I1qGrcmx4z/wr1bRHgnJBdXj8C2u7dBkgnBOme5FKqsMI1U/Gb8cz9fdqOBCQWazB0s7 Oir1/T7cJwCnIKCzYWuFZcDB6IQJ8bfPzPnkYge9zt4x9qXNfnVTLVhETB9dNNmS+Qm1 i8HReInxcLZ1xzp6o2kbMv77R+bdZ1I9GDYs/4jxQ8LvH4gqun31BF1XL1+Y6saZHoKv NVgCQuz0CRtId328AIkm/KT2+YFbYp0ZM24JRz2DMqGYCHKaiWPqRX2Caz6ccQAdWINH 7Nlw== X-Gm-Message-State: APjAAAUw0jGg8zSE+jLTDdABOj1U86GKjU0iDWivaBZyygEJFY4oI3cz TDMhrET9Ik98e8WBwRYofDL+83XFhwRl+lqkZPI= X-Google-Smtp-Source: APXvYqw9QQj9Ti8WKyo8gjlKSpGsqLRG2B9QmRI3Fs3vQL04NHHaPG06xFKmK+ZntPzsDk7jUfioPFAqkeTU3Op2eJs= X-Received: by 2002:a2e:3a13:: with SMTP id h19mr21421766lja.220.1565699777265; Tue, 13 Aug 2019 05:36:17 -0700 (PDT) MIME-Version: 1.0 References: <20190812215052.71840-1-ndesaulniers@google.com> <20190812215052.71840-12-ndesaulniers@google.com> <20190813082744.xmzmm4j675rqiz47@willie-the-truck> In-Reply-To: <20190813082744.xmzmm4j675rqiz47@willie-the-truck> From: Miguel Ojeda Date: Tue, 13 Aug 2019 14:36:06 +0200 Message-ID: Subject: Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h To: Will Deacon Cc: Nick Desaulniers , Andrew Morton , Sedat Dilek , Josh Poimboeuf , yhs@fb.com, clang-built-linux@googlegroups.com, Catalin Marinas , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Andrey Konovalov , Greg Kroah-Hartman , Enrico Weigelt , Suzuki K Poulose , Thomas Gleixner , Masayoshi Mizuma , Shaokun Zhang , Alexios Zavras , Allison Randal , Linux ARM , linux-kernel , Network Development , bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Aug 13, 2019 at 10:27 AM Will Deacon wrote: > > Hi Nick, > > On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > > GCC unescapes escaped string section names while Clang does not. Because > > __section uses the `#` stringification operator for the section name, it > > doesn't need to be escaped. > > > > This antipattern was found with: > > $ grep -e __section\(\" -e __section__\(\" -r > > > > Reported-by: Sedat Dilek > > Suggested-by: Josh Poimboeuf > > Signed-off-by: Nick Desaulniers > > --- > > arch/arm64/include/asm/cache.h | 2 +- > > arch/arm64/kernel/smp_spin_table.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > Does this fix a build issue, or is it just cosmetic or do we end up with > duplicate sections or something else? This should be cosmetic -- basically we are trying to move all users of current available __attribute__s in compiler_attributes.h to the __attr forms. I am also adding (slowly) new attributes that are already used but we don't have them yet in __attr form. > Happy to route it via arm64, just having trouble working out whether it's > 5.3 material! As you prefer! Those that are not taken by a maintainer I will pick up and send via compiler-attributes. I would go for 5.4, since there is no particular rush anyway. Cheers, Miguel