From: Grant Seltzer Richman <grantseltzer@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf <bpf@vger.kernel.org>
Subject: Re: Typical way to handle missing macros in vmlinux.h
Date: Mon, 3 May 2021 14:32:18 -0400 [thread overview]
Message-ID: <CAO658oUpqOHmSAif+6zor1XTruDqHeTzAQHrCXOSPRo6oTp5vg@mail.gmail.com> (raw)
In-Reply-To: <CAEf4Bzayxgt3P+kz36t6C8jp-MUTuwuKvwHWWsd2qrCs3-RHXA@mail.gmail.com>
On Wed, Apr 28, 2021 at 5:15 PM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Wed, Apr 28, 2021 at 1:53 PM Grant Seltzer Richman
> <grantseltzer@gmail.com> wrote:
> >
> > Hi all,
> >
> > I'm working on enabling CO:RE in a project I work on, tracee, and am
> > running into the dilemma of missing macros that we previously were
> > able to import from their various header files. I understand that
> > macros don't make their way into BTF and therefore the generated
> > vmlinux.h won't have them. However I can't import the various header
> > files because of multiple-definition issues.
>
> Sadly, copy/pasting has been the only way so far.
>
> >
> > Do people typically redefine each of these macros for their project?
> > If so is there anything I should be careful of, such as architectural
> > differences. Does anyone have creative ideas, even if not developed
> > fully yet that I can possibly contribute to libbpf?
>
> We've discussed adding Clang built-in to detect if a specific type is
> already defined and doing something like this in vmlinux.h:
>
> #if !__builtin_is_type_defined(struct task_struct)
> struct task_struct {
> ...
> }
> #endif
>
> And just do that for every struct, union, typedef. That would allow
> vmlinux.h to co-exist (somewhat) with other types.
>
> Another alternative is to not use vmlinux.h and use just linux
> headers, but mark necessary types with
> __attribute__((preserve_access_index)) to make them CO-RE relocatable.
> You can add that to existing types with the same pragma that vmlinux.h
> uses.
I'm attempting to try doing the above. I'm just replacing
bpf_probe_read with bpf_core_read and not importing vmlinux.h, just
all the kernel headers I need.
When you say "Add that to existing types with the same pragma that
vmlinux.h uses", Should I be able to add the following to my bpf
source file before importing my headers?
ifndef BPF_NO_PRESERVE_ACCESS_INDEX
#pragma clang attribute push (__attribute__((preserve_access_index)),
apply_to = record)
#endif
and then pop the attribute at the bottom of the file, or after the
header includes.
I've tried this and get a whole bunch of 'unknown attribute' warnings,
leading me to believe that I either have something installed
incorrectly or don't understand how to use clang attributes. Do I need
to edit the types in the actual header files?
Thank you very very much for the help!
- Grant
>
> >
> > Thanks so much,
> > Grant Seltzer
next prev parent reply other threads:[~2021-05-03 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 19:13 Typical way to handle missing macros in vmlinux.h Grant Seltzer Richman
2021-04-28 21:15 ` Andrii Nakryiko
2021-05-03 18:32 ` Grant Seltzer Richman [this message]
2021-05-03 18:43 ` Andrii Nakryiko
2021-05-03 20:20 ` Grant Seltzer Richman
2021-05-03 21:21 ` Andrii Nakryiko
2021-05-04 15:31 ` Grant Seltzer Richman
2021-05-04 16:24 ` Yonghong Song
2021-05-04 16:57 ` Grant Seltzer Richman
2021-05-04 22:31 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO658oUpqOHmSAif+6zor1XTruDqHeTzAQHrCXOSPRo6oTp5vg@mail.gmail.com \
--to=grantseltzer@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).