From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
pablo@netfilter.org, fw@strlen.de,
"toke@redhat.com" <toke@redhat.com>
Subject: Re: [PATCH bpf-next v3 0/3] Add more bpf_*_ct_lookup() selftests
Date: Thu, 11 Aug 2022 02:25:51 +0200 [thread overview]
Message-ID: <CAP01T74aWUW-iyPCV_VfASO6YqfAZmnkYQMN2B4L8ngMMgnAcw@mail.gmail.com> (raw)
In-Reply-To: <cover.1660173222.git.dxu@dxuuu.xyz>
On Thu, 11 Aug 2022 at 01:16, Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> This patchset adds more bpf_*_ct_lookup() selftests. The goal is to test
> interaction with netfilter subsystem as well as reading from `struct
> nf_conn`. The first is important when migrating legacy systems towards
> bpf. The latter is important in general to take full advantage of
> connection tracking.
>
Thank you for contributing these tests. Feel free to add:
Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
People often look at selftests for usage examples these days, so it's
great to have coverage + examples for more use cases.
> I'll follow this patchset up with support for writing to `struct nf_conn`.
>
Please also cc netfilter-devel, netdev, Pablo, and Florian when you send it.
I think we can directly enable stores to ct->mark, since that is what
ctnetlink is doing too, so adding another helper for this would be
unnecessary overhead.
> Past discussion:
> - v2: https://lore.kernel.org/bpf/cover.1660062725.git.dxu@dxuuu.xyz/
> - v1: https://lore.kernel.org/bpf/cover.1659209738.git.dxu@dxuuu.xyz/
>
> Changes since v2:
> - Add bpf-ci kconfig changes
>
> Changes since v1:
> - Reword commit message / cover letter to not mention connmark writing
>
>
> Daniel Xu (3):
> selftests/bpf: Add existing connection bpf_*_ct_lookup() test
> selftests/bpf: Add connmark read test
> selftests/bpf: Update CI kconfig
>
> tools/testing/selftests/bpf/config | 2 +
> .../testing/selftests/bpf/prog_tests/bpf_nf.c | 60 +++++++++++++++++++
> .../testing/selftests/bpf/progs/test_bpf_nf.c | 21 +++++++
> 3 files changed, 83 insertions(+)
>
> --
> 2.37.1
>
next prev parent reply other threads:[~2022-08-11 0:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 23:16 [PATCH bpf-next v3 0/3] Add more bpf_*_ct_lookup() selftests Daniel Xu
2022-08-10 23:16 ` [PATCH bpf-next v3 1/3] selftests/bpf: Add existing connection bpf_*_ct_lookup() test Daniel Xu
2022-08-10 23:25 ` Kumar Kartikeya Dwivedi
2022-08-10 23:16 ` [PATCH bpf-next v3 2/3] selftests/bpf: Add connmark read test Daniel Xu
2022-08-10 23:16 ` [PATCH bpf-next v3 3/3] selftests/bpf: Update CI kconfig Daniel Xu
2022-08-11 0:25 ` Kumar Kartikeya Dwivedi [this message]
2022-08-11 21:50 ` [PATCH bpf-next v3 0/3] Add more bpf_*_ct_lookup() selftests Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP01T74aWUW-iyPCV_VfASO6YqfAZmnkYQMN2B4L8ngMMgnAcw@mail.gmail.com \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dxu@dxuuu.xyz \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).