bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Stringer <joe@ovn.org>
To: Brendan Jackman <jackmanb@google.com>
Cc: luca.boccassi@gmail.com, bpf <bpf@vger.kernel.org>,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Jiong Wang" <jiong.wang@netronome.com>,
	"Jakub Kicinski" <jakub.kicinski@netronome.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <kafai@fb.com>,
	songliubraving@fb.com, "Yonghong Song" <yhs@fb.com>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	daniel@zonque.org, fengc@google.com, jbacik@fb.com,
	"Luca Boccassi" <bluca@debian.org>
Subject: Re: [PATCH] samples/bpf: relicense bpf_insn.h as GPL-2.0-only OR BSD-2-Clause
Date: Tue, 28 Sep 2021 12:09:46 -0700	[thread overview]
Message-ID: <CAPWQB7HBBrP5eQhXnhw5VRMPBRHqXNSi_zmiaE12s==Z1av9HA@mail.gmail.com> (raw)
In-Reply-To: <CA+i-1C3sjrwtskbSZzera7ANL8dTiVWMBwLRhe=+1Ft6NgfL=A@mail.gmail.com>

On Thu, 23 Sept 2021 at 02:42, Brendan Jackman <jackmanb@google.com> wrote:
>
>
>
> On Thu, 23 Sept 2021 at 02:06, <luca.boccassi@gmail.com> wrote:
>>
>> From: Luca Boccassi <bluca@debian.org>
>>
>> libbpf and bpftool have been dual-licensed to facilitate inclusion in
>> software that is not compatible with GPL2-only (ie: Apache2), but the
>> samples are still GPL2-only.
>>
>> Given these files are samples, they get naturally copied around. For example
>> it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
>> tree: https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h
>>
>> Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow
>> the same licensing used by libbpf and bpftool:
>>
>> 1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause")
>> 907b22365115 ("tools: bpftool: dual license all files")
>>
>> Signed-off-by: Luca Boccassi <bluca@debian.org>
>> ---
>> Most of systemd is (L)GPL2-or-later, which means there is no perceived
>> incompatibility with Apache2 softwares and can thus be linked with
>> OpenSSL 3.0. But given this GPL2-only header is included this is currently
>> not possible.
>> Dual-licensing this header solves this problem for us as we are scoping
>> moving to OpenSSL 3.0, see:
>>
>> https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html
>>
>> The authors of this file according to git log are:
>>
>> Alexei Starovoitov <ast@kernel.org>
>> Björn Töpel <bjorn.topel@intel.com>
>> Brendan Jackman <jackmanb@google.com>
>
>
> Acked-by:  Brendan Jackman <jackmanb@google.com>
>
>> Chenbo Feng <fengc@google.com>
>> Daniel Borkmann <daniel@iogearbox.net>
>> Daniel Mack <daniel@zonque.org>
>> Jakub Kicinski <jakub.kicinski@netronome.com>
>> Jiong Wang <jiong.wang@netronome.com>
>> Joe Stringer <joe@ovn.org>
>> Josef Bacik <jbacik@fb.com>
>>
>> (excludes a commit adding the SPDX header)
>>
>> All authors and maintainers are CC'ed. An Acked-by from everyone in the
>> above list of authors will be necessary.
>>
>> One could probably argue for relicensing all the samples/bpf/ files given both
>> libbpf and bpftool are, however the authors list would be much larger and thus
>> it would be much more difficult, so I'd really appreciate if this header could
>> be handled first by itself, as it solves a real license incompatibility issue
>> we are currently facing.
>>
>>  samples/bpf/bpf_insn.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/samples/bpf/bpf_insn.h b/samples/bpf/bpf_insn.h
>> index aee04534483a..29c3bb6ad1cd 100644
>> --- a/samples/bpf/bpf_insn.h
>> +++ b/samples/bpf/bpf_insn.h
>> @@ -1,4 +1,4 @@
>> -/* SPDX-License-Identifier: GPL-2.0 */
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>  /* eBPF instruction mini library */
>>  #ifndef __BPF_INSN_H
>>  #define __BPF_INSN_H
>> --
>> 2.33.0
>>

Acked-by: Joe Stringer <joe@ovn.org>

  parent reply	other threads:[~2021-09-28 19:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23  0:05 [PATCH] samples/bpf: relicense bpf_insn.h as GPL-2.0-only OR BSD-2-Clause luca.boccassi
2021-09-23 10:41 ` Luca Boccassi
2021-09-23 13:42   ` Quentin Monnet
2021-09-23 14:10     ` Simon Horman
2021-09-27 14:07   ` Luca Boccassi
2021-09-27 14:11     ` Daniel Mack
2021-09-27 14:27 ` Luca Boccassi
2021-09-27 14:39   ` Josef Bacik
2021-09-28 15:44 ` Luca Boccassi
2021-09-29 11:01   ` Björn Töpel
2021-09-29 11:05     ` Luca Boccassi
2021-09-29 11:26       ` Magnus Karlsson
2021-09-29 11:27         ` Luca Boccassi
     [not found] ` <CA+i-1C3sjrwtskbSZzera7ANL8dTiVWMBwLRhe=+1Ft6NgfL=A@mail.gmail.com>
2021-09-28 19:09   ` Joe Stringer [this message]
     [not found]     ` <CAMOXUJ=gLLCDv0ZuEz77Qvepx9r0uTfy3J3phWuGPMQXsM1FGA@mail.gmail.com>
2021-09-28 19:12       ` Chenbo Feng
2021-09-29 16:06 ` Luca Boccassi
2021-09-29 16:10   ` Daniel Borkmann
2021-09-29 16:37     ` Luca Boccassi
2021-09-29 16:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPWQB7HBBrP5eQhXnhw5VRMPBRHqXNSi_zmiaE12s==Z1av9HA@mail.gmail.com' \
    --to=joe@ovn.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@intel.com \
    --cc=bluca@debian.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=daniel@zonque.org \
    --cc=fengc@google.com \
    --cc=jackmanb@google.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jbacik@fb.com \
    --cc=jiong.wang@netronome.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=luca.boccassi@gmail.com \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).