bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Song Liu <song@kernel.org>
To: John Fastabend <john.fastabend@gmail.com>
Cc: Alexei Starovoitov <ast@fb.com>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf, selftests: test_maps generating unrecognized data section
Date: Thu, 1 Apr 2021 15:47:54 -0700	[thread overview]
Message-ID: <CAPhsuW4RpdANPWwSv=VBTn+TS-1vF-oc1Xjm=2-baaivFC+_4Q@mail.gmail.com> (raw)
In-Reply-To: <161731595664.74613.1603087410166945302.stgit@john-XPS-13-9370>

On Thu, Apr 1, 2021 at 3:28 PM John Fastabend <john.fastabend@gmail.com> wrote:
>
> With a relatively recent clang master branch test_map skips a section,
>
>  libbpf: elf: skipping unrecognized data section(5) .rodata.str1.1
>
> the cause is some pointless strings from bpf_printks in the BPF program
> loaded during testing. After just removing the prints to fix above
> error Daniel points out the program is a bit pointless and could
> be simply the empty program returning SK_PASS.
>
> Here we do just that and return simply SK_PASS. This program is used with
> test_maps selftests to test insert/remove of a program into the sockmap
> and sockhash maps. Its not testing actual functionality of the TCP sockmap
> programs, these are tested from test_sockmap. So we shouldn't lose in
> test coverage and fix above warnings. This original test was added before
> test_sockmap existed and has been copied around ever since, clean it up
> now.
>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>

Acked-by: Song Liu <songliubraving@fb.com>

  reply	other threads:[~2021-04-01 22:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 22:25 [PATCH bpf-next] bpf, selftests: test_maps generating unrecognized data section John Fastabend
2021-04-01 22:47 ` Song Liu [this message]
2021-04-02 23:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPhsuW4RpdANPWwSv=VBTn+TS-1vF-oc1Xjm=2-baaivFC+_4Q@mail.gmail.com' \
    --to=song@kernel.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=john.fastabend@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).