From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED2DC433DF for ; Wed, 29 Jul 2020 21:37:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A9972053B for ; Wed, 29 Jul 2020 21:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596058633; bh=UztyEnGiszZAILnw87KgVUDMvCNr0XqFqxP9dO/xGpw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Iyt5AiV5P9D44loexC6l+YpeLjsEuSjwmuQT7goN2u3beuwEuwnNDjN6KG6wKuxlw 1xhV/Qs0DcsxxcfW1iig/7B3iXjrjhRgO1Zo8slCPagHUxBkef/qv1WB3t/NV86M48 aZEsXTHbcpfIiy2V94jhNG+kcp5vgoiR6FoEDcxo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726947AbgG2VhM (ORCPT ); Wed, 29 Jul 2020 17:37:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:41946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgG2VhL (ORCPT ); Wed, 29 Jul 2020 17:37:11 -0400 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30D4020809; Wed, 29 Jul 2020 21:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596058631; bh=UztyEnGiszZAILnw87KgVUDMvCNr0XqFqxP9dO/xGpw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tqHm859q/zp4uJFb4WWGa/aIH8ODA7CjKvuMJHjw2hMovYJ0qYme/2LFyZCznuQC/ NWz7Po6VFagFhI7Atk/9dm8GbbzXrMM4BeVcY7G41VsjJrSpjSfVho5bKpVSWkb7Be +EqKdh4u3krI4YmC+QuZk7dyRRMH3WoBQ0Dl+yJM= Received: by mail-lj1-f170.google.com with SMTP id q4so26684116lji.2; Wed, 29 Jul 2020 14:37:11 -0700 (PDT) X-Gm-Message-State: AOAM5311SEI5+KfE0tmivWYBHWjaGobSxb5r+olrgj5+UTV/kM0p52TH ADuAlBy/PWjB2WemAkB3p7Yyfs+BmtZ24WHd4jE= X-Google-Smtp-Source: ABdhPJxPjWwYTRXjxDZVLzGUttpmVCsB7mzIRrLM32Vd2M6yaMZWNqRvZOSjaBUuVhE8M8amiHr+40g3x+ZDNedxTqU= X-Received: by 2002:a2e:8707:: with SMTP id m7mr194379lji.350.1596058629542; Wed, 29 Jul 2020 14:37:09 -0700 (PDT) MIME-Version: 1.0 References: <159603940602.4454.2991262810036844039.stgit@john-Precision-5820-Tower> <159603984765.4454.3932218162163081929.stgit@john-Precision-5820-Tower> In-Reply-To: <159603984765.4454.3932218162163081929.stgit@john-Precision-5820-Tower> From: Song Liu Date: Wed, 29 Jul 2020 14:36:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [bpf PATCH v2 5/5] bpf, selftests: Add tests to sock_ops for loading sk To: John Fastabend Cc: Martin KaFai Lau , Daniel Borkmann , Alexei Starovoitov , Networking , bpf Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Jul 29, 2020 at 9:26 AM John Fastabend wrote: > [...] > > Notice it takes us an extra four instructions when src reg is the > same as dst reg. One to save the reg, two to restore depending on > the branch taken and a goto to jump over the second restore. > > Signed-off-by: John Fastabend Acked-by: Song Liu [...]