From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0CFC5DF60 for ; Fri, 8 Nov 2019 19:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA499206A3 for ; Fri, 8 Nov 2019 19:34:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TcEjfklm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387899AbfKHTeA (ORCPT ); Fri, 8 Nov 2019 14:34:00 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:35855 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387798AbfKHTeA (ORCPT ); Fri, 8 Nov 2019 14:34:00 -0500 Received: by mail-qk1-f194.google.com with SMTP id d13so6326128qko.3; Fri, 08 Nov 2019 11:33:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vVjFDTyHHoe23R65Js+fJ8Q7TkZs+QvYfoQUfDVq0/w=; b=TcEjfklmtjueAi+SFsccwG240WSdsdJRa6/jtA1GROQxG7rcZHbUBhL+oqhbTaPS2B HLW4w0RTrcnomUwXQ2CKOXzAOiDm3+/VsCQt6vOTYGk0tAf7iAnipqO/XNIKfJNfbuZb 2aVoZjPHiJZ0nYPSrvWhQRYAu6PRzj7qZGJ/1LqVTcLnlW4vNIHMLefM43rFhUnS0yrh KIGmPCnC3Di9gJvqBzLG5lg6u093NbTwqak4ZcRIZ2diIGSFVt6j4/cflEABsVKuk6ss dB5g/n+vGUJTgcWuiO4eiHscNMxMjnhnZBkh9H8k1KzK42/YR7fkFSfFdtlTezneHXT2 Rx7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vVjFDTyHHoe23R65Js+fJ8Q7TkZs+QvYfoQUfDVq0/w=; b=DzGU+fpawzzdM48aHy2qlomtJsLSmhmw1NMEkq9oLdR6AnDlJcQgKcQrEFhMMZkM+6 2MATH336Xem9jGuCgPzM4q6dl70hsuorsxKlqHtGjwlOIe/E56aWwawctlUjRhF7KFow Cvus81gJeix68gsRhklSAPl85fe0Dz6m0BmCfO1ywmCqJdFi0ALIj4mj70tteG+7i9kK UOFa3A8cuUoNuhes8dvaM/EABiV3IzwsQ3kfE78FKYLKVYEzkjEopvQ/PjK4X2WzaKqT WG3gs/k23MZ5V9BW7eK59LoyithMC+i3mxBEibpF4Sb7Z2i79kT3qFvlC7vlvPaMWBhq 1wFQ== X-Gm-Message-State: APjAAAWbmWrqUsSyTQlpVomqIqBUIj7TxAVf2SfaJOVAe6mwha1Nc7VC rVjSp5HoIIwxu7xQvtB771MfJrRZXm7l8vw1Kz0QlQ== X-Google-Smtp-Source: APXvYqye2s1OlQRwGHpX8Y5BDWB9Uf1rhcLgoUQOpOrXjN3c0oMJ7m916whutYY/N1N9le/ODEvqTaA5Glbl7aU7I+Q= X-Received: by 2002:a37:b801:: with SMTP id i1mr10915924qkf.497.1573241639236; Fri, 08 Nov 2019 11:33:59 -0800 (PST) MIME-Version: 1.0 References: <157314553801.693412.15522462897300280861.stgit@toke.dk> <157314554027.693412.3764267220990589755.stgit@toke.dk> In-Reply-To: <157314554027.693412.3764267220990589755.stgit@toke.dk> From: Song Liu Date: Fri, 8 Nov 2019 11:33:48 -0800 Message-ID: Subject: Re: [PATCH bpf-next 2/6] selftests/bpf: Add tests for automatic map unpinning on load failure To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Daniel Borkmann , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Jesper Dangaard Brouer , Andrii Nakryiko , David Miller , Networking , bpf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Nov 7, 2019 at 8:52 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > From: Toke H=C3=B8iland-J=C3=B8rgensen > > This add tests for the different variations of automatic map unpinning on > load failure. > > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > --- [...] > diff --git a/tools/testing/selftests/bpf/progs/test_pinning.c b/tools/tes= ting/selftests/bpf/progs/test_pinning.c > index f69a4a50d056..f20e7e00373f 100644 > --- a/tools/testing/selftests/bpf/progs/test_pinning.c > +++ b/tools/testing/selftests/bpf/progs/test_pinning.c > @@ -21,7 +21,7 @@ struct { > } nopinmap SEC(".maps"); > > struct { > - __uint(type, BPF_MAP_TYPE_ARRAY); > + __uint(type, BPF_MAP_TYPE_HASH); Why do we need this change? > __uint(max_entries, 1); > __type(key, __u32); > __type(value, __u64); >