From: Song Liu <liu.song.a23@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next 2/2] bpf: Add loop test case with 32 bit reg comparison against 0
Date: Thu, 3 Oct 2019 13:56:53 -0700 [thread overview]
Message-ID: <CAPhsuW6oGoBK28JyY3r6a+fzesqa8c7Zki+z33XXV2AS6=JVwQ@mail.gmail.com> (raw)
In-Reply-To: <20191002234512.25902-2-daniel@iogearbox.net>
On Wed, Oct 2, 2019 at 5:30 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> Add a loop test with 32 bit register against 0 immediate:
>
> # ./test_verifier 631
> #631/p taken loop with back jump to 1st insn, 2 OK
>
> Disassembly:
>
> [...]
> 1b: test %edi,%edi
> 1d: jne 0x0000000000000014
> [...]
>
> Pretty much similar to prior "taken loop with back jump to 1st
> insn" test case just as jmp32 variant.
>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Song Liu <songliubraving@fb.com>
next prev parent reply other threads:[~2019-10-03 20:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 23:45 [PATCH bpf-next 1/2] bpf, x86: Small optimization in comparing against imm0 Daniel Borkmann
2019-10-02 23:45 ` [PATCH bpf-next 2/2] bpf: Add loop test case with 32 bit reg comparison against 0 Daniel Borkmann
2019-10-03 20:56 ` Song Liu [this message]
2019-10-03 20:52 ` [PATCH bpf-next 1/2] bpf, x86: Small optimization in comparing against imm0 Song Liu
2019-10-03 21:08 ` John Fastabend
2019-10-04 19:36 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW6oGoBK28JyY3r6a+fzesqa8c7Zki+z33XXV2AS6=JVwQ@mail.gmail.com' \
--to=liu.song.a23@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).