From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E34F7C2BB1D for ; Tue, 14 Apr 2020 22:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC6112051A for ; Tue, 14 Apr 2020 22:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586903097; bh=YaJVT/ye1FgBI4JEdpPpiFVU6B7Mpm3hjJhUg2CSA94=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=IRw5RlAPaWjeD12dSCCnWnwbji5n24vz8bVf6vLpt5y+QcgT3HLi6m08xBznWLAcS RjhEBh09rtjEIqeIS1E+0spOZlN3wAuK2SlW5H/TOOB4SBn7vu7evfDAYy/IEhQpmQ AUw8BdisgD1mperuAhYLdEU/RxYwgh+sDi1dGKig= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391861AbgDNWYq (ORCPT ); Tue, 14 Apr 2020 18:24:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:49506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391856AbgDNWYl (ORCPT ); Tue, 14 Apr 2020 18:24:41 -0400 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1270D2076B; Tue, 14 Apr 2020 22:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586903081; bh=YaJVT/ye1FgBI4JEdpPpiFVU6B7Mpm3hjJhUg2CSA94=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JEBHN+5SgmCGJ2yWaSx36uCojxC+aC2BZy6wJlChdqzACq0/GAGcOuw364NP9vCHJ jrHQ4fYIwT4Ktma2GfhGDBGggSaKZTxZTbT1kGwXaXINs5i6zclUfXYoBjTsWc2UvK T13TyNzTVMnQCHu8zQZEvqcYIMJTVJUcPI1DV+2s= Received: by mail-lj1-f175.google.com with SMTP id q22so1600628ljg.0; Tue, 14 Apr 2020 15:24:40 -0700 (PDT) X-Gm-Message-State: AGi0PubcjDtEXCl4PdA6eBfNu6lJTS/67A9TbtduVWTtu5kIcCiN81Tz 6+bCqTlmbTIQNDcqbinmvDGepVElk3ldh54bTZo= X-Google-Smtp-Source: APiQypIAWSIXj7RT/pEoMXOrSMyKd56/mNs4ugtTYhIc9Jk9mRXSGpzm8BvLTnuM4herlwlx8vNNtowRPcFhxbI86Y0= X-Received: by 2002:a05:651c:1a5:: with SMTP id c5mr1383150ljn.113.1586903079191; Tue, 14 Apr 2020 15:24:39 -0700 (PDT) MIME-Version: 1.0 References: <20200414145025.182163-1-toke@redhat.com> In-Reply-To: <20200414145025.182163-1-toke@redhat.com> From: Song Liu Date: Tue, 14 Apr 2020 15:24:28 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf 1/2] libbpf: Fix type of old_fd in bpf_xdp_set_link_opts To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Daniel Borkmann , Alexei Starovoitov , bpf , Networking , David Ahern Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Apr 14, 2020 at 9:20 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > The 'old_fd' parameter used for atomic replacement of XDP programs is > supposed to be an FD, but was left as a u32 from an earlier iteration of > the patch that added it. It was converted to an int when read, so things > worked correctly even with negative values, but better change the > definition to correctly reflect the intention. > > Fixes: bd5ca3ef93cd ("libbpf: Add function to set link XDP fd while speci= fying old program") > Reported-by: David Ahern > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen Acked-by: Song Liu