From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 690FBC07E95 for ; Wed, 7 Jul 2021 16:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5550E61CBE for ; Wed, 7 Jul 2021 16:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbhGGQxi (ORCPT ); Wed, 7 Jul 2021 12:53:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230262AbhGGQxh (ORCPT ); Wed, 7 Jul 2021 12:53:37 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97F11C061760 for ; Wed, 7 Jul 2021 09:50:57 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id q16so2609052qke.10 for ; Wed, 07 Jul 2021 09:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+l8T0NV1W2EFm1dKAG471xyxn7DWyeb0DjrbpB/+e3k=; b=FeKmsw2+/cti+7XaCDgvJURDocUATJdLYv3FDD/2Y1khq8vDyglm6gIN1jBFXwBgwB oEsuqrSJn0o6PZ8XKKantmakJcS42as18I5GSOfewmfqycZ2tZ483gndigPuq7tThC48 5WU0Fq9Hktr8c4EVqVIc3H/cWvsOicXQf41e8uUGuymx2Mg8tX9d+W+oIL2wiLSLR9ju rOeukSo28QD43WY+hVMr1piMVGhyI3SkWXx/no5+P2IKQNiK83UgnF9Iuo20AovmFKDX 50dvBf1FoQKCXKQjZCIx1Jq+aI5DzJLa3MJy9crg7qMnSOscw/+RJsJdEA2QB9Zh+H8k awTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+l8T0NV1W2EFm1dKAG471xyxn7DWyeb0DjrbpB/+e3k=; b=U5ene9mO8Qfj8ByB+e4dXZBrWn/bjeOoBAVrCJJQGTRwDL6xMvUCCxmN4F86sQfb2X mmv29hjwZHd9WgPy4FpFopLB4iwATroabHgIYXB97NY4leJxc+1k9p+eSm3R40/KDUSb rX9fim4WCWKMset5FmqGsc7xGX3YdKRyia1+vh5qt+6WG1cCYLJKOynB+YuZUUPmy4hd 3dSQEMxuJ8CHOFo0uHMOYu0hZWGZ0lRhagq34ccnkIVVXBrrxABbyHn3sxGjqxtDzo+3 WcwdBR/e0Q9mCl5QYCCcC6jk64ehRWhQ4/c0Y+/S7q6Q3g3In5x0dOd76NSrqOmjrhRy n0zg== X-Gm-Message-State: AOAM531zivtw4hevX6+q3kViIcs/cnnaSXF5CDD9Y0VzgVhLVyY2HAdW YukNrPRJclyfmUuTB08/p8HNY93CRnPHpQTSzNhS2w== X-Google-Smtp-Source: ABdhPJz27A76SeAyJWGygXJLAWImPup40+dr2a2Qng83jiPEyrMFJhB2OOcqXf5MT8M+UbL3ZLlBgKHZhBYaKRgrBL4= X-Received: by 2002:a37:c52:: with SMTP id 79mr18962846qkm.295.1625676656506; Wed, 07 Jul 2021 09:50:56 -0700 (PDT) MIME-Version: 1.0 References: <1625044676-12441-1-git-send-email-linyunsheng@huawei.com> <20210702153947.7b44acdf@linux.microsoft.com> <20210706155131.GS22278@shell.armlinux.org.uk> In-Reply-To: From: Marcin Wojtas Date: Wed, 7 Jul 2021 18:50:49 +0200 Message-ID: Subject: Re: [PATCH net-next RFC 0/2] add elevated refcnt support for page pool To: Matteo Croce Cc: "Russell King (Oracle)" , Yunsheng Lin , Sven Auhagen , David Miller , Jakub Kicinski , linuxarm@openeuler.org, yisen.zhuang@huawei.com, salil.mehta@huawei.com, Thomas Petazzoni , Jesper Dangaard Brouer , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrew Morton , Peter Zijlstra , Will Deacon , Matthew Wilcox , Vlastimil Babka , Fenghua Yu , Roman Gushchin , Peter Xu , feng.tang@intel.com, Jason Gunthorpe , Matteo Croce , Hugh Dickins , Jonathan Lemon , Alexander Lobakin , Willem de Bruijn , wenxu , Cong Wang , Kevin Hao , Aleksandr Nogikh , Marco Elver , netdev@vger.kernel.org, Linux Kernel Mailing List , bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi, =C5=9Br., 7 lip 2021 o 01:20 Matteo Croce napi= sa=C5=82(a): > > On Tue, Jul 6, 2021 at 5:51 PM Russell King (Oracle) > wrote: > > > > On Fri, Jul 02, 2021 at 03:39:47PM +0200, Matteo Croce wrote: > > > On Wed, 30 Jun 2021 17:17:54 +0800 > > > Yunsheng Lin wrote: > > > > > > > This patchset adds elevated refcnt support for page pool > > > > and enable skb's page frag recycling based on page pool > > > > in hns3 drvier. > > > > > > > > Yunsheng Lin (2): > > > > page_pool: add page recycling support based on elevated refcnt > > > > net: hns3: support skb's frag page recycling based on page pool > > > > > > > > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 79 +++++++- > > > > drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 3 + > > > > drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 1 + > > > > drivers/net/ethernet/marvell/mvneta.c | 6 +- > > > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- > > > > include/linux/mm_types.h | 2 +- > > > > include/linux/skbuff.h | 4 +- > > > > include/net/page_pool.h | 30 ++- > > > > net/core/page_pool.c | 215 > > > > +++++++++++++++++---- 9 files changed, 285 insertions(+), 57 > > > > deletions(-) > > > > > > > > > > Interesting! > > > Unfortunately I'll not have access to my macchiatobin anytime soon, c= an > > > someone test the impact, if any, on mvpp2? > > > > I'll try to test. Please let me know what kind of testing you're > > looking for (I haven't been following these patches, sorry.) > > > > A drop test or L2 routing will be enough. > BTW I should have the macchiatobin back on friday. I have a 10G packet generator connected to 10G ports of CN913x-DB - I will stress mvpp2 in l2 forwarding early next week (I'm mostly AFK this until Monday). Best regards, Marcin