bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Tim.Bird@sony.com>
To: <cristian.marussi@arm.com>, <skhan@linuxfoundation.org>,
	<alexei.starovoitov@gmail.com>, <daniel@iogearbox.net>
Cc: <linux-kselftest@vger.kernel.org>, <bpf@vger.kernel.org>,
	<netdev@vger.kernel.org>, <davem@davemloft.net>
Subject: RE: Linux 5.4 - bpf test build fails
Date: Tue, 24 Sep 2019 18:07:16 +0000	[thread overview]
Message-ID: <ECADFF3FD767C149AD96A924E7EA6EAF977BCBF5@USCULXMSG01.am.sony.com> (raw)
In-Reply-To: <c3dda8d0-1794-ffd1-4d76-690ac2be8b8f@arm.com>



> -----Original Message-----
> From: Cristian Marussi on Tuesday, September 24, 2019 7:30 AM
> 
> Hi Shuah
> 
> On 24/09/2019 17:39, Shuah Khan wrote:
> > On 9/24/19 10:03 AM, Shuah Khan wrote:
> >> On 9/24/19 9:52 AM, Cristian Marussi wrote:
> >>> Hi Shuah
> >>>
> >>> On 24/09/2019 16:26, Shuah Khan wrote:
> >>>> Hi Alexei and Daniel,
> >>>>
> >>>> bpf test doesn't build on Linux 5.4 mainline. Do you know what's
> >>>> happening here.
> >>>>
> >>>>
> >>>> make -C tools/testing/selftests/bpf/
> >>>
> >>> side question, since I'm writing arm64/ tests.
> >>>
> >>> my "build-testcases" following the KSFT docs are:
> >>>
> >>> make kselftest
> >>> make TARGETS=arm64 kselftest
> >>> make -C tools/testing/selftests/
> >>> make -C tools/testing/selftests/ INSTALL_PATH=<install-path> install
> >>> make TARGETS=arm64 -C tools/testing/selftests/
> >>> make TARGETS=arm64 -C tools/testing/selftests/
> >>> INSTALL_PATH=<install-path> install
> >>> ./kselftest_install.sh <install-path>
> >
> > Cristian,
> >
> > That being said, I definitely want to see this list limited to
> > a few options.
> >
> > One problem is that if somebody wants to do just a build, there
> > is no option from the main makefile. I have sent support for that
> > a few months ago and the patch didn't got lost it appears. I am
> > working on resending those patches. The same is true for install.
> > I sent in a patch for that a while back and I am going to resend.
> > These will make it easier for users.
> >
> > I would really want to get to supporting only these options:
> >
> > These are supported now:
> >
> > make kselftest
> > make TARGETS=arm64 kselftest (one or more targets)
> >
> > Replace the following:
> >
> > make -C tools/testing/selftests/ with
> >
> > make kselftes_build option from main makefile
> >
> > Replace this:
> > make -C tools/testing/selftests/ INSTALL_PATH=<install-path> install
> >
> > with
> > make kselftest_install
> 
> Yes these top level options would be absolutely useful to avoid multiplication
> of build targets to support and test.
> 
> Moreover, currently, since there was a lot of test growing into arm64/
> inside subdirs like arm64/signal, I support (still under review in fact) in the
> arm64/
> toplevel makefile the possibility of building/installing by subdirs only, in order
> to be able to limit what you want to build/install of a TARGET (resulting in
> quicker devel),
> issuing something like:
> 
> make TARGETS=arm64 SUBTARGETS=signal -C tools/testing/selftests/
> 
> if possible, that would be useful if kept functional even in the
> new schema. I mean being able to still issue:
> 
> make TARGETS=arm64 SUBTARGETS=signal kselftes_build

From a user perspective, instead of adding a new SUBTARGETS variable,
I would prefer something like the following:

make TARGET=arm64/signal kselftest_build

If you just add a single flat subsidiary namespace, then it doesn't support further
increasing the directory depth in the future.

 -- Tim

> with the SUBTARGETS= or whatever ENV var handling delegated to the lower
> level
> makefiles (so not handled by the toplevel, but just let go through)
> 
> Cheers
> 
> Cristian
> 
> >
> > That way we can support all the use-cases from the main Makefile
> >
> > thanks,
> > -- Shuah
> >
> >


  reply	other threads:[~2019-09-24 18:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 15:26 Linux 5.4 - bpf test build fails Shuah Khan
2019-09-24 15:43 ` Yonghong Song
2019-09-24 15:48   ` Shuah Khan
2019-09-24 18:49     ` Daniel Borkmann
2019-09-24 18:56       ` Shuah Khan
2019-09-24 19:19         ` Daniel Borkmann
2019-09-24 19:48           ` Shuah Khan
2019-09-24 15:52 ` Cristian Marussi
2019-09-24 16:03   ` Shuah Khan
2019-09-24 16:39     ` Shuah Khan
2019-09-24 17:29       ` Cristian Marussi
2019-09-24 18:07         ` Tim.Bird [this message]
2019-09-24 18:23           ` Shuah Khan
2019-09-25  8:52             ` Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ECADFF3FD767C149AD96A924E7EA6EAF977BCBF5@USCULXMSG01.am.sony.com \
    --to=tim.bird@sony.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).