From: Song Liu <songliubraving@fb.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"kpsingh@chromium.org" <kpsingh@chromium.org>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 4/4] selftests/bpf: add test for bpf_iter_task_vma
Date: Wed, 16 Dec 2020 23:23:24 +0000 [thread overview]
Message-ID: <EE276BC6-9513-414D-91D1-6257909AB952@fb.com> (raw)
In-Reply-To: <29e8f249-a23b-3c17-4000-a4075398b669@fb.com>
> On Dec 16, 2020, at 10:18 AM, Yonghong Song <yhs@fb.com> wrote:
>
[...]
>> +
>> + err = bpf_iter_task_vma__load(skel);
>> + if (CHECK(err, "bpf_iter_task_vma__load", "skeleton load failed\n"))
>> + goto out;
>> +
>> + do_dummy_read(skel->progs.proc_maps);
>
> This do_dummy_read() is not needed, right?
do_dummy_read() helped me got bug in earlier version. I am planning to
change the following to do smaller reads, then do_dummy_read() is no longer
needed.
[...]
>
>> +
>> +SEC("iter.s/task_vma") int proc_maps(struct bpf_iter__task_vma *ctx)
>> +{
>> + struct __vm_area_struct *vma = ctx->vma;
>> + struct seq_file *seq = ctx->meta->seq;
>> + struct task_struct *task = ctx->task;
>> + struct file *file = ctx->file;
>> + char perm_str[] = "----";
>> +
>> + if (task == (void *)0 || vma == (void *)0 || task->pid != pid)
>
> I suppose kernel already filtered all non-group-leader tasks, so here
> we can have task->tgid != pid?
Yeah, that works.
>
>> + return 0;
>
> Using /proc system, user typically do cat /proc/pid/maps. How can we
> have a similar user experience with vma_iter here? One way to do this
> is:
> - We still have this bpf program, filtering based on user pid,
> - normal bpftool iter pin command pid the program to say /sys/fs/bpf/task_vma
> - since "pid" is in a map, user can use bpftool to update "pid"
> with the target pid.
> - "cat /sys/fs/bpf/task_vma" will work.
>
> One thing here is pid and d_path_buf are global (map) variables, so
> if two users are trying to do "cat /sys/fs/bpf/task_vma" at the same
> time, there will be interferences and it will not work.
>
> One possible way is during BPF_ITER_CREATE, we duplicate all program
> maps. But this is unnecessary as in most cases, the bpf_iter is not
> pinned and private to applications.
>
> Any other ideas?
Maybe we can use task local storage for pid and d_path_buf?
To make it more practical, we probably want in kernel filtering based
on pid. IOW, let user specify which task to iterate.
Thanks,
Song
next prev parent reply other threads:[~2020-12-16 23:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 23:36 [PATCH v2 bpf-next 0/4] introduce bpf_iter for task_vma Song Liu
2020-12-15 23:36 ` [PATCH v2 bpf-next 1/4] bpf: introduce task_vma bpf_iter Song Liu
2020-12-16 17:36 ` Yonghong Song
2020-12-16 19:41 ` Song Liu
2020-12-17 0:34 ` Andrii Nakryiko
2020-12-17 1:51 ` Song Liu
2020-12-17 19:03 ` Alexei Starovoitov
2020-12-17 22:08 ` Song Liu
2020-12-18 2:34 ` Alexei Starovoitov
2020-12-18 3:15 ` Yonghong Song
2020-12-18 4:33 ` Song Liu
2020-12-18 5:23 ` Alexei Starovoitov
2020-12-18 16:38 ` Yonghong Song
2020-12-18 17:23 ` Song Liu
2021-01-05 1:46 ` Alexei Starovoitov
2021-01-05 5:47 ` Song Liu
2021-01-05 16:27 ` Alexei Starovoitov
2021-01-05 17:10 ` Song Liu
2021-01-05 17:27 ` Alexei Starovoitov
2021-01-05 19:38 ` Song Liu
2021-01-05 19:46 ` Alexei Starovoitov
2021-01-05 19:51 ` Song Liu
2020-12-15 23:37 ` [PATCH v2 bpf-next 2/4] bpf: allow bpf_d_path in sleepable bpf_iter program Song Liu
2020-12-16 17:41 ` Yonghong Song
2020-12-16 18:15 ` KP Singh
2020-12-16 18:31 ` KP Singh
2021-01-25 12:52 ` Jiri Olsa
2020-12-15 23:37 ` [PATCH v2 bpf-next 3/4] libbpf: introduce section "iter.s/" for " Song Liu
2020-12-16 17:42 ` Yonghong Song
2020-12-16 18:00 ` KP Singh
2020-12-15 23:37 ` [PATCH v2 bpf-next 4/4] selftests/bpf: add test for bpf_iter_task_vma Song Liu
2020-12-16 18:18 ` Yonghong Song
2020-12-16 23:23 ` Song Liu [this message]
2020-12-16 17:00 ` [PATCH v2 bpf-next 0/4] introduce bpf_iter for task_vma Yonghong Song
2020-12-16 17:35 ` Song Liu
2020-12-16 18:31 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EE276BC6-9513-414D-91D1-6257909AB952@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).