From: "Nagaraju, Shwetha" <shwetha.nagaraju@intel.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH intel-net 1/3] ice: synchronize_rcu() when terminating rings
Date: Thu, 31 Mar 2022 13:01:49 +0000 [thread overview]
Message-ID: <MW4PR11MB58223B3518AB85AE56ABEA8E90E19@MW4PR11MB5822.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220317183629.340350-2-maciej.fijalkowski@intel.com>
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Maciej Fijalkowski
> Sent: Friday, March 18, 2022 12:06 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; kuba@kernel.org; bpf@vger.kernel.org;
> davem@davemloft.net; Karlsson, Magnus <magnus.karlsson@intel.com>
> Subject: [Intel-wired-lan] [PATCH intel-net 1/3] ice: synchronize_rcu() when
> terminating rings
>
> Unfortunately, the ice driver doesn't respect the RCU critical section that XSK
> wakeup is surrounded with. To fix this, add synchronize_rcu() calls to paths
> that destroy resources that might be in use.
>
> This was addressed in other AF_XDP ZC enabled drivers, for reference see
> for example commit b3873a5be757 ("net/i40e: Fix concurrency issues
> between config flow and XSK")
>
> Fixes: efc2214b6047 ("ice: Add support for XDP")
> Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice.h | 2 +-
> drivers/net/ethernet/intel/ice/ice_main.c | 4 +++-
> drivers/net/ethernet/intel/ice/ice_xsk.c | 4 +++-
> 3 files changed, 7 insertions(+), 3 deletions(-)
>
Tested-by: Shwetha Nagaraju <Shwetha.nagaraju@intel.com>
next prev parent reply other threads:[~2022-03-31 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 18:36 [PATCH intel-net 0/3] ice: xsk: various fixes Maciej Fijalkowski
2022-03-17 18:36 ` [PATCH intel-net 1/3] ice: synchronize_rcu() when terminating rings Maciej Fijalkowski
2022-03-31 13:01 ` Nagaraju, Shwetha [this message]
2022-03-17 18:36 ` [PATCH intel-net 2/3] ice: xsk: fix VSI state check in ice_xsk_wakeup() Maciej Fijalkowski
2022-03-30 10:20 ` [Intel-wired-lan] " Nagaraju, Shwetha
2022-03-17 18:36 ` [PATCH intel-net 3/3] ice: clear cmd_type_offset_bsz for TX rings Maciej Fijalkowski
2022-04-04 4:34 ` [Intel-wired-lan] " Nagaraju, Shwetha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB58223B3518AB85AE56ABEA8E90E19@MW4PR11MB5822.namprd11.prod.outlook.com \
--to=shwetha.nagaraju@intel.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).