From: "Kuruvinakunnel, George" <george.kuruvinakunnel@intel.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "joamaki@gmail.com" <joamaki@gmail.com>,
"Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"toke@redhat.com" <toke@redhat.com>,
"bjorn@kernel.org" <bjorn@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH v7 intel-next 6/9] ice: propagate xdp_ring onto rx_ring
Date: Fri, 3 Sep 2021 06:45:30 +0000 [thread overview]
Message-ID: <PH0PR11MB51440C7E16476F0583A279B7E2CF9@PH0PR11MB5144.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210819120004.34392-7-maciej.fijalkowski@intel.com>
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Maciej
> Fijalkowski
> Sent: Thursday, August 19, 2021 5:30 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: joamaki@gmail.com; Lobakin, Alexandr <alexandr.lobakin@intel.com>;
> netdev@vger.kernel.org; toke@redhat.com; bjorn@kernel.org; kuba@kernel.org;
> bpf@vger.kernel.org; davem@davemloft.net; Karlsson, Magnus
> <magnus.karlsson@intel.com>
> Subject: [Intel-wired-lan] [PATCH v7 intel-next 6/9] ice: propagate xdp_ring onto
> rx_ring
>
> With rings being split, it is now convenient to introduce a pointer to XDP ring within
> the Rx ring. For XDP_TX workloads this means that xdp_rings array access will be
> skipped, which was executed per each processed frame.
>
> Also, read the XDP prog once per NAPI and if prog is present, set up the local
> xdp_ring pointer. Reading prog a single time was discussed in [1] with some
> concern raised by Toke around dispatcher handling and having the need for going
> through the RCU grace period in the ndo_bpf driver callback, but ice currently is
> torning down NAPI instances regardless of the prog presence on VSI.
>
> Although the pointer to XDP ring introduced to Rx ring makes things a lot
> slimmer/simpler, I still feel that single prog read per NAPI lifetime is beneficial.
>
> Further patch that will introduce the fallback path will also get a profit from that as
> xdp_ring pointer will be set during the XDP rings setup.
>
> [1]: https://lore.kernel.org/bpf/87k0oseo6e.fsf@toke.dk/
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 3 +++
> drivers/net/ethernet/intel/ice/ice_txrx.c | 23 +++++++++--------
> drivers/net/ethernet/intel/ice/ice_txrx.h | 1 +
> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 10 +++-----
> drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 2 +-
> drivers/net/ethernet/intel/ice/ice_xsk.c | 25 +++++++++++--------
> 6 files changed, 35 insertions(+), 29 deletions(-)
>
Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
next prev parent reply other threads:[~2021-09-03 6:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 11:59 [PATCH v7 intel-next 0/9] XDP_TX improvements for ice Maciej Fijalkowski
2021-08-19 11:59 ` [PATCH v7 intel-next 1/9] ice: remove ring_active from ice_ring Maciej Fijalkowski
2021-09-13 6:47 ` [Intel-wired-lan] " G, GurucharanX
2021-08-19 11:59 ` [PATCH v7 intel-next 2/9] ice: move ice_container_type onto ice_ring_container Maciej Fijalkowski
2021-09-13 6:50 ` [Intel-wired-lan] " G, GurucharanX
2021-08-19 11:59 ` [PATCH v7 intel-next 3/9] ice: split ice_ring onto Tx/Rx separate structs Maciej Fijalkowski
2021-09-22 18:28 ` [Intel-wired-lan] " G, GurucharanX
2021-08-19 11:59 ` [PATCH v7 intel-next 4/9] ice: unify xdp_rings accesses Maciej Fijalkowski
2021-09-03 6:37 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 5/9] ice: do not create xdp_frame on XDP_TX Maciej Fijalkowski
2021-09-03 6:40 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 6/9] ice: propagate xdp_ring onto rx_ring Maciej Fijalkowski
2021-09-03 6:45 ` Kuruvinakunnel, George [this message]
2021-08-19 12:00 ` [PATCH v7 intel-next 7/9] ice: optimize XDP_TX workloads Maciej Fijalkowski
2021-09-03 6:50 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 8/9] ice: introduce XDP_TX fallback path Maciej Fijalkowski
2021-09-03 6:50 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 9/9] ice: make use of ice_for_each_* macros Maciej Fijalkowski
2021-09-22 18:26 ` [Intel-wired-lan] " G, GurucharanX
2021-08-25 7:57 ` [Intel-wired-lan] [PATCH v7 intel-next 0/9] XDP_TX improvements for ice Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB51440C7E16476F0583A279B7E2CF9@PH0PR11MB5144.namprd11.prod.outlook.com \
--to=george.kuruvinakunnel@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joamaki@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).