From: Alok Prasad <palok@marvell.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Ariel Elior <aelior@marvell.com>
Cc: GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"hawk@kernel.org" <hawk@kernel.org>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: RE: [EXT] [PATCH] qed: Fix missing error code in qed_slowpath_start()
Date: Mon, 11 Oct 2021 05:17:32 +0000 [thread overview]
Message-ID: <SJ0PR18MB3900AFB7ECA41BC29B73B1B3A1B59@SJ0PR18MB3900.namprd18.prod.outlook.com> (raw)
In-Reply-To: <1633766966-115907-1-git-send-email-jiapeng.chong@linux.alibaba.com>
> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: 09 October 2021 13:39
> To: Ariel Elior <aelior@marvell.com>
> Cc: GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>; davem@davemloft.net;
> kuba@kernel.org; linux@armlinux.org.uk; ast@kernel.org; daniel@iogearbox.net;
> hawk@kernel.org; john.fastabend@gmail.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; bpf@vger.kernel.org; chongjiapeng
> <jiapeng.chong@linux.alibaba.com>
> Subject: [EXT] [PATCH] qed: Fix missing error code in qed_slowpath_start()
>
> External Email
>
> ----------------------------------------------------------------------
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'rc'.
>
> Eliminate the follow smatch warning:
>
> drivers/net/ethernet/qlogic/qed/qed_main.c:1298 qed_slowpath_start()
> warn: missing error code 'rc'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: d51e4af5c209 ("qed: aRFS infrastructure support")
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/ethernet/qlogic/qed/qed_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c
> b/drivers/net/ethernet/qlogic/qed/qed_main.c
> index 5e7242304ee2..359ad859ae18 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
> @@ -1295,6 +1295,7 @@ static int qed_slowpath_start(struct qed_dev *cdev,
> } else {
> DP_NOTICE(cdev,
> "Failed to acquire PTT for aRFS\n");
> + rc = -EINVAL;
> goto err;
> }
> }
> --
> 2.19.1.6.gb485710b
Thanks!
Acked-by: Alok Prasad <palok@marvell.com>
prev parent reply other threads:[~2021-10-11 5:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 8:09 [PATCH] qed: Fix missing error code in qed_slowpath_start() Jiapeng Chong
2021-10-09 12:50 ` patchwork-bot+netdevbpf
2021-10-11 5:17 ` Alok Prasad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR18MB3900AFB7ECA41BC29B73B1B3A1B59@SJ0PR18MB3900.namprd18.prod.outlook.com \
--to=palok@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).