bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Santucci Pierpaolo <santucci@epigenesys.com>
To: shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
	andrii@kernel.org, john.fastabend@gmail.com,
	kpsingh@chromium.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH v2] selftest/bpf: fix IPV6FR handling in flow dissector
Date: Mon, 16 Nov 2020 11:30:37 +0100	[thread overview]
Message-ID: <X7JUzUj34ceE2wBm@santucci.pierpaolo> (raw)
In-Reply-To: <X6rJ7c1C95uNZ/xV@santucci.pierpaolo>

From second fragment on, IPV6FR program must stop the dissection of IPV6
fragmented packet. This is the same approach used for IPV4 fragmentation.
This fixes the flow keys calculation for the upper-layer protocols.
Note that according to RFC8200, the first fragment packet must include
the upper-layer header.

Signed-off-by: Santucci Pierpaolo <santucci@epigenesys.com>
---
v2: extend the commit message, as suggested by John Fastabend
    <john.fastabend@gmail.com>

 tools/testing/selftests/bpf/progs/bpf_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/bpf/progs/bpf_flow.c b/tools/testing/selftests/bpf/progs/bpf_flow.c
index 5a65f6b51377..95a5a0778ed7 100644
--- a/tools/testing/selftests/bpf/progs/bpf_flow.c
+++ b/tools/testing/selftests/bpf/progs/bpf_flow.c
@@ -368,6 +368,8 @@ PROG(IPV6FR)(struct __sk_buff *skb)
 		 */
 		if (!(keys->flags & BPF_FLOW_DISSECTOR_F_PARSE_1ST_FRAG))
 			return export_flow_keys(keys, BPF_OK);
+	} else {
+		return export_flow_keys(keys, BPF_OK);
 	}
 
 	return parse_ipv6_proto(skb, fragh->nexthdr);
-- 
2.17.5


  parent reply	other threads:[~2020-11-16 11:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 17:12 [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector Santucci Pierpaolo
2020-11-11  4:48 ` Andrii Nakryiko
2020-11-11 11:17   ` Jakub Sitnicki
2020-11-11 14:12     ` Santucci Pierpaolo
2020-11-11 23:06       ` Daniel Borkmann
2020-11-12  9:00         ` Jakub Sitnicki
2020-11-13  0:50           ` John Fastabend
2020-11-16 10:30 ` Santucci Pierpaolo [this message]
2020-11-16 12:18   ` [PATCH v2] " Jakub Sitnicki
2020-11-16 16:10   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X7JUzUj34ceE2wBm@santucci.pierpaolo \
    --to=santucci@epigenesys.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).