From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
cgroups@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Song Liu <songliubraving@fb.com>,
bpf@vger.kernel.org, Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH v2] perf stat: Support old kernels for bperf cgroup counting
Date: Fri, 14 Oct 2022 10:30:52 -0300 [thread overview]
Message-ID: <Y0lkjJLfZNXQNYxR@kernel.org> (raw)
In-Reply-To: <Y0ljzN920sWalEHR@kernel.org>
Em Fri, Oct 14, 2022 at 10:27:40AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Oct 11, 2022 at 06:53:43AM -1000, Tejun Heo escreveu:
> > On Mon, Oct 10, 2022 at 10:28:08PM -0700, Namhyung Kim wrote:
> > > The recent change in the cgroup will break the backward compatiblity in
> > > the BPF program. It should support both old and new kernels using BPF
> > > CO-RE technique.
>
> > > Like the task_struct->__state handling in the offcpu analysis, we can
> > > check the field name in the cgroup struct.
>
> > > Acked-by: Jiri Olsa <jolsa@kernel.org>
> > > Acked-by: Andrii Nakryiko <andrii@kernel.org>
> > > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> > Applied to cgroup/for-6.1-fixes.
>
> Hey, I noticed that the perf build is broken for the
> tools/perf/util/bpf_skel/bperf_cgroup.bpf.c skell, so I tried using b4
> on this Namhyung patch, it ended up getting a newer version, by Tejun,
> that mixes up kernel code and tooling, which, when I tried to apply
> upstream didn't work.
>
> Please try not to mix up kernel and tools/ changes in the same patch to
> avoid these issues.
>
> Also when changing tools/perf, please CC me.
>
> I'm now back trying to apply v2 of this patch to see if it fixes my
> build.
Yeah, applying just Namhyung's v2 patch gets perf back building, I'll
keep it there while processing the other patches so that I can test them
all together.
- Arnaldo
next prev parent reply other threads:[~2022-10-14 13:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAM9d7cjQ20a01YoZi=o-_7HT6TzR0TZgtpscKNvRrMq2yqV1Og@mail.gmail.com>
2022-09-22 4:14 ` [PATCH] perf stat: Support old kernels for bperf cgroup counting Namhyung Kim
2022-09-24 3:22 ` Tejun Heo
2022-09-30 20:30 ` Namhyung Kim
2022-09-30 21:43 ` Jiri Olsa
2022-09-30 21:56 ` Namhyung Kim
2022-09-30 22:00 ` Arnaldo Carvalho de Melo
2022-09-30 22:11 ` Namhyung Kim
2022-10-01 13:57 ` Jiri Olsa
2022-09-30 22:48 ` Andrii Nakryiko
2022-10-01 2:31 ` Namhyung Kim
2022-10-05 22:36 ` Andrii Nakryiko
2022-10-01 13:58 ` Jiri Olsa
2022-10-10 23:59 ` Tejun Heo
2022-10-11 5:24 ` Namhyung Kim
2022-10-11 5:28 ` [PATCH v2] " Namhyung Kim
2022-10-11 16:53 ` Tejun Heo
2022-10-14 13:27 ` Arnaldo Carvalho de Melo
2022-10-14 13:30 ` Arnaldo Carvalho de Melo [this message]
2022-10-14 16:40 ` Tejun Heo
2022-10-14 17:10 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0lkjJLfZNXQNYxR@kernel.org \
--to=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).