From: Jiri Olsa <olsajiri@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Jiri Olsa <olsajiri@gmail.com>, Ian Rogers <irogers@google.com>,
Mike Leach <mike.leach@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, peterz@infradead.org, mingo@redhat.com,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
namhyung@kernel.org
Subject: Re: [PATCH v3 1/2] perf build: Properly guard libbpf includes
Date: Tue, 10 Jan 2023 14:39:08 +0100 [thread overview]
Message-ID: <Y71qfFoQp6AR8K6D@krava> (raw)
In-Reply-To: <Y71pl/6yrhIWjYOe@kernel.org>
On Tue, Jan 10, 2023 at 10:35:19AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 10, 2023 at 12:19:53PM +0100, Jiri Olsa escreveu:
> > On Mon, Jan 09, 2023 at 11:34:44AM -0800, Ian Rogers wrote:
> > > Oh, just to note. While failing the feature test is disappointing for
> > > a libbpf that isn't very old, we have the newer libbpf to statically
> > > build in. Developers won't be impacted due to the static route. If you
> > > are a distro maintainer, you should just update your libbpf. So we
> > > could just bump the API assumption to 1.0 as I believe that'd have the
> > > advantage of removing feature tests, workarounds, untested code (like
> > > what broke here), etc.
>
> > > What do you think?
>
> > yes, seems good.. fedora has libbpf 1.0 already so should not be problem
> > there at least ;-)
>
> So, I already pushed 1/2 to perf/urgent, can I stick an Acked-by: jolsa
> to the second?
yes
jirka
next prev parent reply other threads:[~2023-01-10 13:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 15:13 [PATCH v3 1/2] perf build: Properly guard libbpf includes Ian Rogers
2023-01-06 15:13 ` [PATCH v3 2/2] perf build: Fix build error when NO_LIBBPF=1 Ian Rogers
2023-01-06 15:28 ` [PATCH v3 1/2] perf build: Properly guard libbpf includes Mike Leach
2023-01-06 17:25 ` Arnaldo Carvalho de Melo
2023-01-06 17:53 ` Arnaldo Carvalho de Melo
2023-01-06 17:55 ` Arnaldo Carvalho de Melo
2023-01-06 19:06 ` Ian Rogers
2023-01-09 15:12 ` Arnaldo Carvalho de Melo
2023-01-09 18:10 ` Jiri Olsa
2023-01-09 18:37 ` Ian Rogers
2023-01-09 19:29 ` Ian Rogers
2023-01-09 19:34 ` Ian Rogers
2023-01-09 20:40 ` Ian Rogers
2023-01-10 11:19 ` Jiri Olsa
2023-01-10 13:35 ` Arnaldo Carvalho de Melo
2023-01-10 13:39 ` Jiri Olsa [this message]
2023-01-10 14:31 ` Arnaldo Carvalho de Melo
2023-01-10 14:46 ` Arnaldo Carvalho de Melo
2023-01-10 20:00 ` Ian Rogers
2023-01-06 17:57 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y71qfFoQp6AR8K6D@krava \
--to=olsajiri@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).