From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E72DBC433E6 for ; Tue, 9 Feb 2021 09:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD29364EBE for ; Tue, 9 Feb 2021 09:35:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbhBIJey (ORCPT ); Tue, 9 Feb 2021 04:34:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50882 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229908AbhBIJcb (ORCPT ); Tue, 9 Feb 2021 04:32:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612863064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=viYH64kE+WC0LkmBd6WghQDv2YxKbctUtjEzyPFmzQQ=; b=QcC0zYeJFTsGR5rXp8W/CP5LalyUONDCyD3/lh5DSQHZoI3ajH2nRHFAeW+3bvw4O1VKmo jaatZpvmyOy9zw2Gy3odOBZAU/p6QcMCZr4iwAPYfNFO0bB+6vakF1V+lIlem9Zdt28U1J 4SZfARi1SzAe9FIixjkXaVmb9h8eOkM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-567-AYRTBPTpNaCmWw_qqyDD0A-1; Tue, 09 Feb 2021 04:31:00 -0500 X-MC-Unique: AYRTBPTpNaCmWw_qqyDD0A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9EFC63FD6; Tue, 9 Feb 2021 09:30:57 +0000 (UTC) Received: from krava (unknown [10.40.195.89]) by smtp.corp.redhat.com (Postfix) with SMTP id 9FE0060CCF; Tue, 9 Feb 2021 09:30:53 +0000 (UTC) Date: Tue, 9 Feb 2021 10:30:52 +0100 From: Jiri Olsa To: Andrii Nakryiko Cc: Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Networking , bpf , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Masahiro Yamada , Michal Marek , Linux Kbuild mailing list Subject: Re: [PATCHv2 bpf-next 0/4] kbuild/resolve_btfids: Invoke resolve_btfids clean in root Makefile Message-ID: References: <20210205124020.683286-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Feb 08, 2021 at 09:36:40PM -0800, Andrii Nakryiko wrote: > On Fri, Feb 5, 2021 at 4:45 AM Jiri Olsa wrote: > > > > hi, > > resolve_btfids tool is used during the kernel build, > > so we should clean it on kernel's make clean. > > > > v2 changes: > > - add Song's acks on patches 1 and 4 (others changed) [Song] > > - add missing / [Andrii] > > - change srctree variable initialization [Andrii] > > - shifted ifdef for clean target [Andrii] > > > > thanks, > > jirka > > > > > > --- > > Jiri Olsa (4): > > tools/resolve_btfids: Build libbpf and libsubcmd in separate directories > > tools/resolve_btfids: Check objects before removing > > tools/resolve_btfids: Set srctree variable unconditionally > > kbuild: Add resolve_btfids clean to root clean target > > > > Makefile | 7 ++++++- > > tools/bpf/resolve_btfids/.gitignore | 2 -- > > tools/bpf/resolve_btfids/Makefile | 44 ++++++++++++++++++++++---------------------- > > 3 files changed, 28 insertions(+), 25 deletions(-) > > > > I've applied the changes to the bpf-next tree. Thanks. > > Next time please make sure that each patch in the series has a v2 tag > in [PATCH] section, it was a bit confusing to figure out which one is > the actual v2 version. Our tooling (CI) also expects the format [PATCH > v2 bpf-next], so try not to merge v2 with PATCH. > will do, thanks jirka