From: Heiko Carstens <hca@linux.ibm.com>
To: Yonghong Song <yhs@fb.com>
Cc: Ilya Leoshkevich <iii@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
bpf@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH v3 bpf-next] selftests/bpf: Use the last page in test_snprintf_btf on s390
Date: Sun, 28 Feb 2021 09:02:32 +0100 [thread overview]
Message-ID: <YDtOGOktRc/QZIDF@osiris> (raw)
In-Reply-To: <21c13c15-0dbc-8430-9e04-0932f6f913f0@fb.com>
On Fri, Feb 26, 2021 at 07:47:02PM -0800, Yonghong Song wrote:
> > test_snprintf_btf fails on s390, because NULL points to a readable
> > struct lowcore there. Fix by using the last page instead.
> >
> > Error message example:
> >
> > printing 0000000000000000 should generate error, got (361)
> >
> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> > ---
> > v2 -> v3: Heiko mentioned that using _REGION1_SIZE is not future-proof.
> > We had a private discussion and came to the conclusion that
> > the the last page is good enough.
>
> Heiko, could you ack the patch if it is okay? Thanks!
Yes, sure.
Acked-by: Heiko Carstens <hca@linux.ibm.com>
prev parent reply other threads:[~2021-02-28 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 19:09 [PATCH v3 bpf-next] selftests/bpf: Use the last page in test_snprintf_btf on s390 Ilya Leoshkevich
2021-02-27 3:47 ` Yonghong Song
2021-02-27 5:13 ` Ilya Leoshkevich
2021-02-28 8:02 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDtOGOktRc/QZIDF@osiris \
--to=hca@linux.ibm.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gor@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).