From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A05A8C433B4 for ; Tue, 6 Apr 2021 18:03:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67542613CC for ; Tue, 6 Apr 2021 18:03:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237055AbhDFSDm (ORCPT ); Tue, 6 Apr 2021 14:03:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:35894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236565AbhDFSDl (ORCPT ); Tue, 6 Apr 2021 14:03:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7636161154; Tue, 6 Apr 2021 18:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617732212; bh=7j9GmUZpSnlPxAKxWA/IqA7Y9fT7sbk0lvqEkScqtw8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VDw1hzgqCcMreZ0eLTvZDPyGeg0tIteSFhwSW5RRc3lbhCpIkYQ2sT/S9WXJYbDBu 2vdcMbtbe+lgp/mA3uSvpwB7GKFkti3hJcJJDzJJXwvUnySuIqzUm9i9VSxobSJn7r m/7VqiEUoNXl0GFrYD3APjlfiXDa1Qh8nOEm7r6A1apUbOuwef/9d9SfBPoU5/s/kz RErwQiqbaSh5kOQDfqclssQfKoj9Ck5ShHmIXnsOUsFuDjFDwE2ChNroXl9xQ01lQ8 syFiAzazXT08FHFg5O2/c5wVQDuhHFu8vM3OFtYhMYiMDcr++DkQbD6hMRdDAcoEI+ d/k6wp9t7wkWg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0F4C440647; Tue, 6 Apr 2021 15:03:29 -0300 (-03) Date: Tue, 6 Apr 2021 15:03:28 -0300 From: Arnaldo Carvalho de Melo To: Yonghong Song Cc: Bill Wendling , Jiri Olsa , dwarves@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , bpf , David Blaikie , =?utf-8?B?RsSBbmctcnXDrCBTw7JuZw==?= , kernel-team@fb.com, Nick Desaulniers Subject: Re: [PATCH dwarves 0/2] dwarf_loader: improve cus__merging_cu() Message-ID: References: <06ba2ed4-2730-9ce8-0665-3c720bc786a3@fb.com> <3a6aa243-add9-88a5-b405-85fd8bfbe21d@fb.com> <4eda63d8-f9df-71ab-d625-dcc4df429a89@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4eda63d8-f9df-71ab-d625-dcc4df429a89@fb.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Em Tue, Apr 06, 2021 at 10:48:22AM -0700, Yonghong Song escreveu: > > > On 4/6/21 10:23 AM, Yonghong Song wrote: > > > > > > On 4/6/21 10:03 AM, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Apr 06, 2021 at 01:59:30PM -0300, Arnaldo Carvalho de Melo > > > escreveu: > > > > Em Tue, Apr 06, 2021 at 01:55:54PM -0300, Arnaldo Carvalho de > > > > Melo escreveu: > > > > > Em Tue, Apr 06, 2021 at 01:40:20PM -0300, Arnaldo Carvalho > > > > > de Melo escreveu: > > > > > > Em Tue, Apr 06, 2021 at 10:22:37AM -0300, Arnaldo > > > > > > Carvalho de Melo escreveu: > > > > > > > I'm seeing these here: > > > > > > > > > > > > [acme@five bpf]$ rm -f ../build/bpf_clang_thin_lto/*vmlinu* > > > > > > > [acme@five bpf]$ time make -j28 LLVM=1 LLVM_IAS=1 > > > > > > > O=../build/bpf_clang_thin_lto/ vmlinux > > > > > > > make[1]: Entering directory '/home/acme/git/build/bpf_clang_thin_lto' > > > > > > >    GEN     Makefile > > > > > > >    DESCEND  objtool > > > > > > >    DESCEND  bpf/resolve_btfids > > > > > > >    CALL    /home/acme/git/bpf/scripts/atomic/check-atomics.sh > > > > > > >    CALL    /home/acme/git/bpf/scripts/checksyscalls.sh > > > > > > >    CHK     include/generated/compile.h > > > > > > >    GEN     .version > > > > > > >    CHK     include/generated/compile.h > > > > > > >    UPD     include/generated/compile.h > > > > > > >    CC      init/version.o > > > > > > >    AR      init/built-in.a > > > > > > >    GEN     .tmp_initcalls.lds > > > > > > >    LTO     vmlinux.o > > > > > > >    OBJTOOL vmlinux.o > > > > > > > vmlinux.o: warning: objtool: > > > > > > > aesni_gcm_init_avx_gen2()+0x12: unsupported stack > > > > > > > pointer realignment > > > > > > > vmlinux.o: warning: objtool: > > > > > > > aesni_gcm_enc_update_avx_gen2()+0x12: unsupported > > > > > > > stack pointer realignment > > > > > > > vmlinux.o: warning: objtool: > > > > > > > aesni_gcm_dec_update_avx_gen2()+0x12: unsupported > > > > > > > stack pointer realignment > > > > > > > vmlinux.o: warning: objtool: > > > > > > > aesni_gcm_finalize_avx_gen2()+0x12: unsupported > > > > > > > stack pointer realignment > > > > > > > vmlinux.o: warning: objtool: > > > > > > > aesni_gcm_init_avx_gen4()+0x12: unsupported stack > > > > > > > pointer realignment > > > > > > > vmlinux.o: warning: objtool: > > > > > > > aesni_gcm_enc_update_avx_gen4()+0x12: unsupported > > > > > > > stack pointer realignment > > > > > > > vmlinux.o: warning: objtool: > > > > > > > aesni_gcm_dec_update_avx_gen4()+0x12: unsupported > > > > > > > stack pointer realignment > > > > > > > vmlinux.o: warning: objtool: > > > > > > > aesni_gcm_finalize_avx_gen4()+0x12: unsupported > > > > > > > stack pointer realignment > > > > > > >    MODPOST vmlinux.symvers > > > > > > >    MODINFO modules.builtin.modinfo > > > > > > >    GEN     modules.builtin > > > > > > >    LD      .tmp_vmlinux.btf > > > > > > >    BTF     .btf.vmlinux.bin.o > > > > > > >    LD      .tmp_vmlinux.kallsyms1 > > > > > > >    KSYMS   .tmp_vmlinux.kallsyms1.S > > > > > > >    AS      .tmp_vmlinux.kallsyms1.S > > > > > > >    LD      .tmp_vmlinux.kallsyms2 > > > > > > >    KSYMS   .tmp_vmlinux.kallsyms2.S > > > > > > >    AS      .tmp_vmlinux.kallsyms2.S > > > > > > >    LD      vmlinux > > > > > > >    BTFIDS  vmlinux > > > > > > > WARN: multiple IDs found for 'inode': 232, 28822 - using 232 > > > > > > > WARN: multiple IDs found for 'file': 374, 28855 - using 374 > > > > > > > WARN: multiple IDs found for 'path': 379, 28856 - using 379 > > > > > > > WARN: multiple IDs found for 'vm_area_struct': 177, 28929 - using 177 > > > > > > > WARN: multiple IDs found for 'task_struct': 97, 28966 - using 97 > > > > > > > WARN: multiple IDs found for 'seq_file': 510, 29059 - using 510 > > > > > > > WARN: multiple IDs found for 'inode': 232, 29345 - using 232 > > > > > > > WARN: multiple IDs found for 'file': 374, 29429 - using 374 > > > > > > > WARN: multiple IDs found for 'path': 379, 29430 - using 379 > > > > > > > WARN: multiple IDs found for 'vm_area_struct': 177, 29471 - using 177 > > > > > > > WARN: multiple IDs found for 'task_struct': 97, 29481 - using 97 > > > > > > > WARN: multiple IDs found for 'seq_file': 510, 29512 - using 510 > > > > > > >    SORTTAB vmlinux > > > > > > >    SYSMAP  System.map > > > > > > > make[1]: Leaving directory '/home/acme/git/build/bpf_clang_thin_lto' > > > > > > > > > > > > > > [acme@five pahole]$ clang -v > > > > > > > clang version 11.0.0 (Fedora 11.0.0-2.fc33) > > > > This could be due to the compiler. The clang 11 is used here. Sedat is > > using clang 12 and didn't see warnings and I am using clang dev branch > > (clang 13) and didn't see warnings either. clang 11 could generate > > some debuginfo where pahole didn't handle it properly. > > > > I tried to build locally with clang 11 but it crashed as I enabled > > assert during compiler build. Will try a little bit more. > > Yes, I can see it with llvm11: > > LD vmlinux > > > BTFIDS vmlinux > > > WARN: multiple IDs found for 'inode': 245, 36255 - using 245 > > > WARN: multiple IDs found for 'file': 390, 36288 - using 390 > > > WARN: multiple IDs found for 'path': 395, 36289 - using 395 > > > WARN: multiple IDs found for 'vm_area_struct': 190, 36362 - using 190 > > > WARN: multiple IDs found for 'task_struct': 93, 36399 - using 93 > > > WARN: multiple IDs found for 'seq_file': 524, 36498 - using 524 > > > WARN: multiple IDs found for 'inode': 245, 36784 - using 245 > > > WARN: multiple IDs found for 'file': 390, 36868 - using 390 > > > WARN: multiple IDs found for 'path': 395, 36869 - using 395 > > > WARN: multiple IDs found for 'vm_area_struct': 190, 36910 - using 190 > > > WARN: multiple IDs found for 'task_struct': 93, 36920 - using 93 > > > WARN: multiple IDs found for 'seq_file': 524, 36951 - using 524 > > > SORTTAB vmlinux > > > SYSMAP System.map > > > LTO [M] crypto/crypto_engine.lto.o > > > LTO [M] drivers/crypto/virtio/virtio_crypto.lto.o > > $ clang --version > clang version 11.1.0 (https://github.com/llvm/llvm-project.git > 1fdec59bffc11ae37eb51a1b9869f0696bfd5312) > Target: x86_64-unknown-linux-gnu > Thread model: posix > InstalledDir: /home/yhs/work/llvm-project/llvm/build/install/bin > > clang12 is okay: > > LTO vmlinux.o > OBJTOOL vmlinux.o > MODPOST vmlinux.symvers > MODINFO modules.builtin.modinfo > GEN modules.builtin > LD .tmp_vmlinux.btf > BTF .btf.vmlinux.bin.o > LD .tmp_vmlinux.kallsyms1 > KSYMS .tmp_vmlinux.kallsyms1.S > AS .tmp_vmlinux.kallsyms1.S > LD .tmp_vmlinux.kallsyms2 > KSYMS .tmp_vmlinux.kallsyms2.S > > $ clang --version > clang version 12.0.0 (https://github.com/llvm/llvm-project.git > 31001be371e8f2c74470e727e54503fb2aabec8b) > Target: x86_64-unknown-linux-gnu > Thread model: posix > InstalledDir: /home/yhs/work/llvm-project/llvm/build/install/bin > > I think we do not need to fix pahole for llvm11. > When linus tree 5.12 is out. clang 12 should have been released > or very close, we can just recommend clang 12 and later. Agreed, and it is just for _thin_ LTO, those warnings don't pop up when building for full LTO with clang 11, the one in Fedora 33. And Fedora 34 beta has clang/llvm 12.0, so we're good. /me goes back to building clang/llvm HEAD, reducing the number of linker instances to 1 as I have just 32GB of ram in this Ryzen machine... ;-) - Arnaldo