From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07ECFC43461 for ; Sat, 10 Apr 2021 00:11:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D188161108 for ; Sat, 10 Apr 2021 00:11:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235262AbhDJAMG (ORCPT ); Fri, 9 Apr 2021 20:12:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235214AbhDJAMF (ORCPT ); Fri, 9 Apr 2021 20:12:05 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D17A0C061763 for ; Fri, 9 Apr 2021 17:11:51 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id g66-20020a1c39450000b0290125d187ba22so3267569wma.2 for ; Fri, 09 Apr 2021 17:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fA8Z5aUUNElBHQmTl0rVRM8cCmxTfIGvqWZXobJvnWQ=; b=CtMvdE66Fm4dWjje6zKsz5kv72mdudXYT7IjWrKjKo1ElzVKNAsIxbE4ZKxunfPt2/ 8ie4/TsZVuhs4+43rmUlu+6M5YlxQlZEbyG1HgCeyhrzubvSiO1oRRhBFP93PkeXTXNQ aHTar9XiwUAq8rpKJmYWgPOZbUDWF22pGOe2uku4LffjB5xotLkIyhkxdoq9Mbkt9xnT e08O690WOfdvLNwLu8dTOPL9slPOPP4GCBz8q2w/IqHXGhvq71v3FiDWd63lPEpLH88S KqfyPamBXXC2iXxWp3jZZJH7Gg2oV2dtcUo55+5gXdpVcjJXcYI02ISu0xYho/CKXJaX CL0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fA8Z5aUUNElBHQmTl0rVRM8cCmxTfIGvqWZXobJvnWQ=; b=jDyZSoAEhZMpWRxQ84WXQyDn7+cPlA42nuZza29mmCHY5+PyEITGEh9TPbKNW/97YG HAHjIVdako/2a7auEwb+S2aqZONF9N9HD9n0QC/z+lXV/5RAaETTjQRdut9w4zhN1yjI Vy30WN9WX8as8p24t/0Vhcw2Qc+U2fQ/ZcV9rl6cUZ3BUz4KSI1mCjTUZuSnSmnGKBXG R2RMuiFgTnv9OgF/Lj7aeXgHmYOaigiya283YQOslaApehnzEn0RyCZFohUMXy1OHzsr fSKjR9CihZXXQNJRlgTU9D+mWNwhtNE9gHlEVlkkt88g8Gg5C2LZtp5U5FahoTU7WuNc h8Fg== X-Gm-Message-State: AOAM530x+U/gp8h0cjFAKhTt0vmmObf6MyHMfiApH4wD+jr8N45LsFhn 0rsnzsZAEBEr6HnFv2vkYu/DgA== X-Google-Smtp-Source: ABdhPJzAaP35Kiw87xpUTi5qQTsrRoBKS6TFnZdpjti+HlUXGZNQDuwqZCfg9FEauKEV6I1dmHPq2w== X-Received: by 2002:a7b:c38d:: with SMTP id s13mr15914875wmj.147.1618013510497; Fri, 09 Apr 2021 17:11:50 -0700 (PDT) Received: from apalos.home (ppp-94-65-225-75.home.otenet.gr. [94.65.225.75]) by smtp.gmail.com with ESMTPSA id p10sm6815210wmi.0.2021.04.09.17.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 17:11:50 -0700 (PDT) Date: Sat, 10 Apr 2021 03:11:45 +0300 From: Ilias Apalodimas To: Matteo Croce Cc: netdev@vger.kernel.org, linux-mm@kvack.org, Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski , Thomas Petazzoni , Marcin Wojtas , Russell King , Mirko Lindner , Stephen Hemminger , Tariq Toukan , Jesper Dangaard Brouer , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Boris Pismenny , Arnd Bergmann , Andrew Morton , "Peter Zijlstra (Intel)" , Vlastimil Babka , Yu Zhao , Will Deacon , Michel Lespinasse , Fenghua Yu , Roman Gushchin , Hugh Dickins , Peter Xu , Jason Gunthorpe , Guoqing Jiang , Jonathan Lemon , Alexander Lobakin , Cong Wang , wenxu , Kevin Hao , Aleksandr Nogikh , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Miaohe Lin , Yunsheng Lin , Guillaume Nault , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Matthew Wilcox , Eric Dumazet , David Ahern , Lorenzo Bianconi , Saeed Mahameed , Andrew Lunn , Paolo Abeni Subject: Re: [PATCH net-next v3 3/5] page_pool: Allow drivers to hint on SKB recycling Message-ID: References: <20210409223801.104657-1-mcroce@linux.microsoft.com> <20210409223801.104657-4-mcroce@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409223801.104657-4-mcroce@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi Matteo, [...] > +bool page_pool_return_skb_page(void *data); > + > struct page_pool *page_pool_create(const struct page_pool_params *params); > > #ifdef CONFIG_PAGE_POOL > @@ -243,4 +247,13 @@ static inline void page_pool_ring_unlock(struct page_pool *pool) > spin_unlock_bh(&pool->ring.producer_lock); > } > > +/* Store mem_info on struct page and use it while recycling skb frags */ > +static inline > +void page_pool_store_mem_info(struct page *page, struct xdp_mem_info *mem) > +{ > + u32 *xmi = (u32 *)mem; > + I just noticed this changed from the original patchset I was carrying. On the original, I had a union containing a u32 member to explicitly avoid this casting. Let's wait for comments on the rest of the series, but i'd like to change that back in a v4. Aplogies, I completely missed this on the previous postings ... Thanks /Ilias