From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yonghong Song <yhs@fb.com>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
Jonathan Corbet <corbet@lwn.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
linux-doc@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH bpf-next] bpf: Document the pahole release info related to libbpf in bpf_devel_QA.rst
Date: Fri, 23 Apr 2021 15:20:13 -0300 [thread overview]
Message-ID: <YIMP3flCE6uwYp69@kernel.org> (raw)
In-Reply-To: <221ef66a-a7e4-14b7-e085-6062e8547b11@fb.com>
Em Thu, Apr 22, 2021 at 09:12:19PM -0700, Yonghong Song escreveu:
>
>
> On 4/22/21 6:23 PM, Tiezhu Yang wrote:
> > pahole starts to use libbpf definitions and APIs since v1.13 after the
> > commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
> > It works well with the git repository because the libbpf submodule will
> > use "git submodule update --init --recursive" to update.
> >
> > Unfortunately, the default github release source code does not contain
> > libbpf submodule source code and this will cause build issues, the tarball
> > from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
> > github, you can get the source tarball with corresponding libbpf submodule
> > codes from
> >
> > https://fedorapeople.org/~acme/dwarves
> >
> > This change documents the above issues to give more information so that
> > we can get the tarball from the right place, early discussion is here:
> >
> > https://lore.kernel.org/bpf/2de4aad5-fa9e-1c39-3c92-9bb9229d0966@loongson.cn/
> >
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > ---
> > Documentation/bpf/bpf_devel_QA.rst | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/bpf/bpf_devel_QA.rst b/Documentation/bpf/bpf_devel_QA.rst
> > index d05e67e..253496a 100644
> > --- a/Documentation/bpf/bpf_devel_QA.rst
> > +++ b/Documentation/bpf/bpf_devel_QA.rst
> > @@ -449,6 +449,19 @@ from source at
> > https://github.com/acmel/dwarves
> > +pahole starts to use libbpf definitions and APIs since v1.13 after the
> > +commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
> > +It works well with the git repository because the libbpf submodule will
> > +use "git submodule update --init --recursive" to update.
> > +
> > +Unfortunately, the default github release source code does not contain
> > +libbpf submodule source code and this will cause build issues, the tarball
> > +from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
> > +github, you can get the source tarball with corresponding libbpf submodule
> > +codes from
> > +
> > +https://fedorapeople.org/~acme/dwarves
> > +
>
> Arnaldo, could you take a look at this patch? Thanks!
Sure, he documented it as I expected from a previous interaction about
this. Would be good to add a paragraph stating how to grab libbpf and
graft it even on a tarball not containing it tho.
Bonus points if the cmake files gets changed in a way that this gets
notified to the user in the error message.
But these suggestions can come in another patch, for this I can give my:
Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo
> > Some distros have pahole version 1.16 packaged already, e.g.
> > Fedora, Gentoo.
next prev parent reply other threads:[~2021-04-23 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 1:23 [PATCH bpf-next] bpf: Document the pahole release info related to libbpf in bpf_devel_QA.rst Tiezhu Yang
2021-04-23 4:12 ` Yonghong Song
2021-04-23 18:20 ` Arnaldo Carvalho de Melo [this message]
2021-04-24 0:12 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIMP3flCE6uwYp69@kernel.org \
--to=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yangtiezhu@loongson.cn \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).