From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0580C433B4 for ; Mon, 26 Apr 2021 19:16:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AADC61154 for ; Mon, 26 Apr 2021 19:16:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240170AbhDZTRg (ORCPT ); Mon, 26 Apr 2021 15:17:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35061 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240168AbhDZTRf (ORCPT ); Mon, 26 Apr 2021 15:17:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619464613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+m/OUrHh3g4mK0h/qw2Ncm9r9mZhHFjbsMaT14s9/xM=; b=gkUwvFIZomzmSzXgwpgTcQ66qlmAYi+5S6v+K0sCsFE0lG+OTWEAVAdPYi20kzjwMYUAS4 yBfxPbuneJWgUAGNxELx5M2R3L71LU8wZHsEJO/mjXfeIfny18QjkcIrC4Q0ii9jhsIw8G ECfnjRw+W9suul6QHnYf0C7jgZM0jXw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-131-UX4RxFe9MxCdOK3I904KJQ-1; Mon, 26 Apr 2021 15:16:47 -0400 X-MC-Unique: UX4RxFe9MxCdOK3I904KJQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6137801814; Mon, 26 Apr 2021 19:16:44 +0000 (UTC) Received: from krava (unknown [10.40.193.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id B75985D9F0; Mon, 26 Apr 2021 19:16:37 +0000 (UTC) Date: Mon, 26 Apr 2021 21:16:36 +0200 From: Jiri Olsa To: Yonghong Song Cc: Michal =?iso-8859-1?Q?Such=E1nek?= , linux-kernel@vger.kernel.org, Martin KaFai Lau , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Song Liu , John Fastabend , KP Singh , netdev@vger.kernel.org, bpf@vger.kernel.org, Jiri Olsa , Jesper Dangaard Brouer Subject: Re: linux-next failing build due to missing cubictcp_state symbol Message-ID: References: <20210423130530.GA6564@kitsune.suse.cz> <316e86f9-35cc-36b0-1594-00a09631c736@fb.com> <20210423175528.GF6564@kitsune.suse.cz> <20210425111545.GL15381@kitsune.suse.cz> <20210426113215.GM15381@kitsune.suse.cz> <20210426121220.GN15381@kitsune.suse.cz> <20210426121401.GO15381@kitsune.suse.cz> <49f84147-bf32-dc59-48e0-f89241cf6264@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Apr 26, 2021 at 06:03:19PM +0200, Jiri Olsa wrote: > On Mon, Apr 26, 2021 at 08:41:49AM -0700, Yonghong Song wrote: > > > > > > On 4/26/21 5:14 AM, Michal Suchánek wrote: > > > On Mon, Apr 26, 2021 at 02:12:20PM +0200, Michal Suchánek wrote: > > > > On Mon, Apr 26, 2021 at 01:32:15PM +0200, Michal Suchánek wrote: > > > > > On Sun, Apr 25, 2021 at 01:15:45PM +0200, Michal Suchánek wrote: > > > > > > On Fri, Apr 23, 2021 at 07:55:28PM +0200, Michal Suchánek wrote: > > > > > > > On Fri, Apr 23, 2021 at 07:41:29AM -0700, Yonghong Song wrote: > > > > > > > > > > > > > > > > > > > > > > > > On 4/23/21 6:05 AM, Michal Suchánek wrote: > > > > > > > > > Hello, > > > > > > > > > > > > > > > > > > I see this build error in linux-next (config attached). > > > > > > > > > > > > > > > > > > [ 4939s] LD vmlinux > > > > > > > > > [ 4959s] BTFIDS vmlinux > > > > > > > > > [ 4959s] FAILED unresolved symbol cubictcp_state > > > > > > > > > [ 4960s] make[1]: *** > > > > > > > > > [/home/abuild/rpmbuild/BUILD/kernel-vanilla-5.12~rc8.next.20210422/linux-5.12-rc8-next-20210422/Makefile:1277: > > > > > > > > > vmlinux] Error 255 > > > > > > > > > [ 4960s] make: *** [../Makefile:222: __sub-make] Error 2 > > this one was reported by Jesper and was fixed by upgrading pahole > that contains the new function generation fixes (v1.19) > > > > > > > > > > > > > > > > > Looks like you have DYNAMIC_FTRACE config option enabled already. > > > > > > > > Could you try a later version of pahole? > > > > > > > > > > > > > > Is this requireent new? > > > > > > > > > > > > > > I have pahole 1.20, and master does build without problems. > > > > > > > > > > > > > > If newer version is needed can a check be added? > > > > > > > > > > > > With dwarves 1.21 some architectures are fixed and some report other > > > > > > missing symbol. Definitely an improvenent. > > > > > > > > > > > > I see some new type support was added so it makes sense if that type is > > > > > > used the new dwarves are needed. > > > > > > > > > > Ok, here is the current failure with dwarves 1.21 on 5.12: > > > > > > > > > > [ 2548s] LD vmlinux > > > > > [ 2557s] BTFIDS vmlinux > > > > > [ 2557s] FAILED unresolved symbol vfs_truncate > > > > > [ 2558s] make[1]: *** > > > > > [/home/abuild/rpmbuild/BUILD/kernel-kvmsmall-5.12.0/linux-5.12/Makefile:1213: > > > > > vmlinux] Error 255 > > > > This is PPC64, from attached config: > > CONFIG_PPC64=y > > I don't have environment to cross-compile for PPC64. > > Jiri, could you take a look? Thanks! > > looks like vfs_truncate did not get into BTF data, > I'll try to reproduce I can't reproduce the problem, in both cross build and native ppc, but the .config attached does not see complete, could you pelase resend? thanks, jirka