From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06983C433ED for ; Thu, 13 May 2021 06:31:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B41CC610CA for ; Thu, 13 May 2021 06:31:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230495AbhEMGcR (ORCPT ); Thu, 13 May 2021 02:32:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:43180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230478AbhEMGcR (ORCPT ); Thu, 13 May 2021 02:32:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 976566140C; Thu, 13 May 2021 06:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620887468; bh=oUUxSFKC5Esvog88XM0Ob0aPuROiYlnR/XXefgK7lT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kB0UKNEQJ6A+GeMmTSeJV0fSXT9weoPlMiMUMPeQS3EhVZTQYY84NAteMtnxBg4nx BK/LwCJC1JqOGFZkErj36T4DRs5qQUq+6D6/n7ZvlFtXkHXVgElEsBrxvdmx4IVsMY jPpFzs/08SIzkmtUX+9rSI7WSTk0Gq2aD9gPW4Y+sE8rvsIwYSqPgeGq/o5QTcLQ7G 8ri3Pqb2d0AJsBTsZisa1ahveRgDhamwHTU4yztJn+xy1ZO/qVAOLPtCk2hkHkM0Rj DT8hjfeBTRHm/WfwwGphobLUZy7PjOaUqVbpNsxHPxfdXZ2ADtywOs1jRbdBuPRDA6 95HM7w5mycgww== Date: Thu, 13 May 2021 09:31:04 +0300 From: Leon Romanovsky To: Andrii Nakryiko Cc: Zhen Lei , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , netdev , bpf Subject: Re: [PATCH 1/1] libbpf: Delete an unneeded bool conversion Message-ID: References: <20210510124315.3854-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, May 12, 2021 at 12:02:11PM -0700, Andrii Nakryiko wrote: > On Mon, May 10, 2021 at 10:09 PM Leon Romanovsky wrote: > > > > On Mon, May 10, 2021 at 11:00:29AM -0700, Andrii Nakryiko wrote: > > > On Mon, May 10, 2021 at 5:43 AM Zhen Lei wrote: > > > > > > > > The result of an expression consisting of a single relational operator is > > > > already of the bool type and does not need to be evaluated explicitly. > > > > > > > > No functional change. > > > > > > > > Signed-off-by: Zhen Lei > > > > --- > > > > > > See [0] and [1]. > > > > > > [0] https://lore.kernel.org/bpf/CAEf4BzYgLf5g3oztbA-CJR4gQ7AVKQAGrsHWCOgTtUMUM-Mxfg@mail.gmail.com/ > > > [1] https://lore.kernel.org/bpf/CAEf4BzZQ6=-h3g1duXFwDLr92z7nE6ajv8Rz_Zv=qx=-F3sRVA@mail.gmail.com/ > > > > How long do you plan to fight with such patches? > > As long as necessary. There are better ways to contribute to libbpf > than doing cosmetic changes to the perfectly correct code. I wish you good luck with that. My hope that, you have enough spare time to invest in rejects. Thanks