From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE7C1C47089 for ; Thu, 27 May 2021 21:08:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C81FD613EC for ; Thu, 27 May 2021 21:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234330AbhE0VKT (ORCPT ); Thu, 27 May 2021 17:10:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36844 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233387AbhE0VKS (ORCPT ); Thu, 27 May 2021 17:10:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622149724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RKrYNji3/LjAeH1E7Kgk4A4XbVR0vhaXNDJXT3n+9D4=; b=EIrzLMfLabQmg69sOuuVcW0FQ+bW0W4LMYTBan7hqyby9ts2YQ0so/qBUNijTmSu/5WJ62 MQwHMrml172d2Jau7wh9rfBoODitWMLEHNWvIeJrORbkewBaWdpA0AMyglcFqRJcScpd5r 4818HPPgKEcbpSuKKZs4/vvRyscTWs8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-U0eyb8fOM0OUmTX3WRqkJg-1; Thu, 27 May 2021 17:08:42 -0400 X-MC-Unique: U0eyb8fOM0OUmTX3WRqkJg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C9567800D55; Thu, 27 May 2021 21:08:40 +0000 (UTC) Received: from krava (unknown [10.40.192.4]) by smtp.corp.redhat.com (Postfix) with SMTP id 4D8FE5D9C6; Thu, 27 May 2021 21:08:34 +0000 (UTC) Date: Thu, 27 May 2021 23:08:33 +0200 From: Jiri Olsa To: Andrii Nakryiko Cc: Arnaldo , Arnaldo Carvalho de Melo , Andrii Nakryiko , Jiri Olsa , Michal =?iso-8859-1?Q?Such=E1nek?= , dwarves@vger.kernel.org, bpf , Kernel Team , Michael Petlan Subject: Re: [RFT] Testing 1.22 Message-ID: References: <4615C288-2CFD-483E-AB98-B14A33631E2F@gmail.com> <4901AF88-0354-428B-9305-2EDC6F75C073@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, May 27, 2021 at 01:41:13PM -0700, Andrii Nakryiko wrote: > On Thu, May 27, 2021 at 12:57 PM Arnaldo wrote: > > > > > > > > On May 27, 2021 4:14:17 PM GMT-03:00, Andrii Nakryiko wrote: > > >On Thu, May 27, 2021 at 12:06 PM Arnaldo > > >wrote: > > >> > > >> > > >> > > >> On May 27, 2021 1:54:40 PM GMT-03:00, Andrii Nakryiko > > > wrote: > > >> >On Thu, May 27, 2021 at 8:20 AM Arnaldo Carvalho de Melo > > >> > wrote: > > >> >> > > >> >> Hi guys, > > >> >> > > >> >> Its important to have 1.22 out of the door ASAP, so please > > >> >clone > > >> >> what is in tmp.master and report your results. > > >> >> > > >> > > > >> >Hey Arnaldo, > > >> > > > >> >If we are going to make pahole 1.22 a new mandatory minimal version > > >of > > >> >pahole, I think we should take a little bit of time and fix another > > >> >problematic issue and clean up Kbuild significantly. > > >> > > > >> >We discussed this before, it would be great to have an ability to > > >dump > > >> >generated BTF into a separate file instead of modifying vmlinux > > >image > > >> >in place. I'd say let's try to push for [0] to land as a temporary > > >> >work around to buy us a bit of time to implement this feature. Then, > > >> >when pahole 1.22 is released and packaged into major distros, we can > > >> >follow up in kernel with Kbuild clean ups and making pahole 1.22 > > >> >mandatory. > > >> > > > >> >What do you think? If anyone agrees, please consider chiming in on > > >the > > >> >above thread ([0]). > > >> > > >> There's multiple fixes that affects lots of stakeholders, so I'm more > > >inclined to release 1.22 sooner rather than later. > > >> > > >> If anyone has cycles right now to work on that detached BTF feature, > > >releasing 1.23 as soon as that feature is complete and tested shouldn't > > >be a problem. > > >> > > >> Then 1.23 the mandatory minimal version. > > >> > > >> Wdyt? > > > > > >If we make 1.22 mandatory there will be no good reason to make 1.23 > > >mandatory again. So I will have absolutely no inclination to work on > > >this, for example. So we are just wasting a chance to clean up the > > >Kbuild story w.r.t. pahole. And we are talking about just a few days > > >at most, while we do have a reasonable work around on the kernel side. > > > > So there were patches for stop using objcopy, which we thought could uncover some can of worms, were there patches for the detached BTF file? > > No, there weren't, if I remember correctly. What's the concern, > though? That detached BTF file isn't even an ELF, so it's > btf__get_raw_data() and write it to the file. Done. heya, I probably overlooked this, but are there more details about that detached BTF file feature somewhere? thanks, jirka