From: Greg KH <gregkh@linuxfoundation.org>
To: Rumen Telbizov <rumen.telbizov@menlosecurity.com>
Cc: bpf@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH 1/3] bpf: Add support for mark with bpf_fib_lookup
Date: Tue, 29 Jun 2021 19:50:24 +0200 [thread overview]
Message-ID: <YNtdYESlf558ONT9@kroah.com> (raw)
In-Reply-To: <CA+FoirAaqbnYan2NEQVaxZ2s_brPNZ02hRFhW9miyfqn+KVGbA@mail.gmail.com>
On Tue, Jun 29, 2021 at 10:37:34AM -0700, Rumen Telbizov wrote:
> Add support for policy routing via marks to the bpf_fib_lookup
> helper. The bpf_fib_lookup struct is constrained to 64B for
> performance. Since the smac and dmac entries are used only for
> output, put them in an anonymous struct and then add a union
> around a second struct that contains the mark to use in the FIB
> lookup.
>
> Signed-off-by: David Ahern <dsahern@kernel.org>
> Signed-off-by: Rumen Telbizov <telbizov@gmail.com>
> ---
> include/uapi/linux/bpf.h | 16 ++++++++++++++--
> net/core/filter.c | 4 ++--
> 2 files changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index ec6d85a81744..6c78cc9c3c75 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -5925,8 +5925,20 @@ struct bpf_fib_lookup {
> /* output */
> __be16 h_vlan_proto;
> __be16 h_vlan_TCI;
> - __u8 smac[6]; /* ETH_ALEN */
> - __u8 dmac[6]; /* ETH_ALEN */
> +
> + union {
> + /* input */
> + struct {
> + __u32 mark; /* fwmark for policy routing */
> + /* 2 4-byte holes for input */
> + };
Tabs seem to be eaten and spit back out with spaces from your email
client :(
next prev parent reply other threads:[~2021-06-29 17:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 17:37 [PATCH 1/3] bpf: Add support for mark with bpf_fib_lookup Rumen Telbizov
2021-06-29 17:50 ` Greg KH [this message]
2021-06-29 17:50 ` Greg KH
2021-06-29 19:10 ` David Ahern
2021-06-29 17:51 ` Toke Høiland-Jørgensen
2021-06-29 18:06 ` Rumen Telbizov
2021-06-29 18:13 ` Greg KH
2021-06-29 18:22 ` Rumen Telbizov
2021-06-29 18:55 [PATCH 0/3] Add support for fwmark to bpf_fib_lookup Rumen Telbizov
2021-06-29 18:55 ` [PATCH 1/3] bpf: Add support for mark with bpf_fib_lookup Rumen Telbizov
2021-06-30 5:35 ` Greg KH
2021-06-30 14:26 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNtdYESlf558ONT9@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=rumen.telbizov@menlosecurity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).