From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E14A4C433F5 for ; Wed, 6 Oct 2021 09:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAA2661166 for ; Wed, 6 Oct 2021 09:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231240AbhJFJee (ORCPT ); Wed, 6 Oct 2021 05:34:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31351 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbhJFJed (ORCPT ); Wed, 6 Oct 2021 05:34:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633512761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ECWtJ9QunQv65wT2NBwXFG9aqNsz/pIxF2+1QOW9wjA=; b=HOPrOjWNiORAaw7it+Wxd7E9ajA/ZXn1L3TwPzQVbVrxDyG4aGr/kpHLJptHEG+SumyotK pCknEZ2s6HYO0RE+HU/i7tezTzwxouFpTtBa1WrqoULz0F4/E7IsazehbnQm4yT9ZgQKHi qlEahhd8rMbE52Ta9R61oolxJc2l4dQ= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528--nkZn9o3PpiA_sMvTXsseg-1; Wed, 06 Oct 2021 05:32:40 -0400 X-MC-Unique: -nkZn9o3PpiA_sMvTXsseg-1 Received: by mail-ed1-f70.google.com with SMTP id x5-20020a50f185000000b003db0f796903so2040022edl.18 for ; Wed, 06 Oct 2021 02:32:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ECWtJ9QunQv65wT2NBwXFG9aqNsz/pIxF2+1QOW9wjA=; b=JmIJ/iWgMrThB033Fh/p10efmboakKcb9x8QBYeaSSHB/NmcH6t8UpMPRlsqdJOlOK TtLOqgTlArG1WbKzDlzKTo2ALyQVKCkCgBlUxnjCEGVVQYE22BqkZyzhdTIZhbsYm5G3 I52euzczDJVG8kl7ccaTl0Osn2TvTAb+6XP/ZOVXUu3bcct3g77bJxR9NHRcwWH3CW0M btCWKeGjNfl8EHcfluQCPfB6SBpEb1BAgkihwxlUBmnMclRF7LBLkqDmG/K9WPex4HcM eUPISZ1LDQrn+81IRYIJ0ewMEviZYpg/ulb1fhIwFTbOdGnL9RknEVXQXoXO2oBY3MFQ lbDg== X-Gm-Message-State: AOAM531sL2UmL9kyDu7DUoumfKdTo9G81FKojFYiXxdSSKqkGNOwuWha qqx0pyuCnmTzeWWVozbXUk2tASyz02FFd7pvv8DaPXwEwzmVVlN4bsgZhGlPevfKpZyKScwmn8r Im+j4paxRnOuw X-Received: by 2002:a05:6402:2345:: with SMTP id r5mr23107526eda.202.1633512759420; Wed, 06 Oct 2021 02:32:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwb2h3XjvEjOiYMPuThj33eVzgF4sHQOJ008r2ma1zLc9i0RRK6Xywd9T4NbpEbKL9DwY6ZNg== X-Received: by 2002:a05:6402:2345:: with SMTP id r5mr23107502eda.202.1633512759227; Wed, 06 Oct 2021 02:32:39 -0700 (PDT) Received: from localhost (net-130-25-199-50.cust.vodafonedsl.it. [130.25.199.50]) by smtp.gmail.com with ESMTPSA id rv25sm5944673ejb.21.2021.10.06.02.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 02:32:38 -0700 (PDT) Date: Wed, 6 Oct 2021 11:32:36 +0200 From: Lorenzo Bianconi To: Jakub Kicinski Cc: Lorenzo Bianconi , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , Alexei Starovoitov , Lorenz Bauer , bpf , Networking , "David S . Miller" , Alexei Starovoitov , Daniel Borkmann , shayagr@amazon.com, John Fastabend , David Ahern , Jesper Dangaard Brouer , Eelco Chaudron , Jason Wang , Alexander Duyck , Saeed Mahameed , Maciej Fijalkowski , "Karlsson, Magnus" , tirthendu.sarkar@intel.com Subject: Re: [PATCH v14 bpf-next 00/18] mvneta: introduce XDP multi-buffer support Message-ID: References: <20210916095539.4696ae27@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <87v92jinv7.fsf@toke.dk> <20210929122229.1d0c4960@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <87mtnvi0bc.fsf@toke.dk> <20211001113528.79f35460@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dJuMWhS9OkhSNQ/M" Content-Disposition: inline In-Reply-To: <20211001113528.79f35460@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org --dJuMWhS9OkhSNQ/M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Fri, 1 Oct 2021 11:03:58 +0200 Lorenzo Bianconi wrote: > > Can you please check if the code above is aligned to current requiremen= ts or if > > it is missing something? > > If this code it is fine, I guess we have two option here: > > - integrate the commits above in xdp multi-buff series (posting v15) an= d work on > > the verfier code in parallel (if xdp_mb_pointer helper is not require= d from day0) > > - integrate verfier changes in xdp multi-buff series, drop bpf_xdp_load= _bytes > > helper (probably we will still need bpf_xdp_store_bytes) and introduce > > bpf_xdp_pointer as new ebpf helper. >=20 > It wasn't clear to me that we wanted bpf_xdp_load_bytes() to exist. > But FWIW no preference here. >=20 ack, same here. Any other opinion about it? Regards, Lorenzo --dJuMWhS9OkhSNQ/M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYV1tNAAKCRA6cBh0uS2t rG9nAQDzRFQNbjpBmGFTPDTbGEDK2wN/GbIWFg9xqUtOkdPHJgD/clbax0bO8iir IHebO6l7i4OZq1Wi3wYrxjIRmdc4pgw= =i6/e -----END PGP SIGNATURE----- --dJuMWhS9OkhSNQ/M--