From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yonghong Song <yhs@fb.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
dwarves@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com
Subject: Re: [PATCH dwarves v2 0/2] generate BTF_KIND_TAG types from DW_TAG_LLVM_annotation dwarf tags
Date: Mon, 27 Sep 2021 17:40:09 -0300 [thread overview]
Message-ID: <YVIsKZTWlDugv3Yz@kernel.org> (raw)
In-Reply-To: <20210922021321.2286360-1-yhs@fb.com>
Em Tue, Sep 21, 2021 at 07:13:21PM -0700, Yonghong Song escreveu:
> LLVM has implemented btf_tag attribute ([1]) which intended
> to provide a "string" tag for struct/union or its member, var,
> a func or its parameter. Such a "string" tag will be encoded
> in dwarf. For non-BPF target like x86_64, pahole needs to
> convert those dwarf btf_tag annotations to BTF so kernel
> can utilize these "string" tags for bpf program verification, etc.
>
> Patch 1 enhanced dwarf_loader to encode DW_TAG_LLVM_annotation
> tags into internal data structure and Patch 2 will encode
> such information to BTF with BTF_KIND_TAGs.
>
> [1] https://reviews.llvm.org/D106614
Applied both locally, now building HEAD llvm/clang to test everything,
- Arnaldo
> Changelog:
> v1 -> v2:
> - handle returning error cases for btf_encoder__add_tag().
>
> Yonghong Song (2):
> dwarf_loader: parse dwarf tag DW_TAG_LLVM_annotation
> btf_encoder: generate BTF_KIND_TAG from llvm annotations
>
> btf_encoder.c | 63 ++++++++++++++++++++++++++++++++++++-
> dwarf_loader.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++----
> dwarves.h | 10 ++++++
> pahole.c | 8 +++++
> 4 files changed, 159 insertions(+), 7 deletions(-)
>
> --
> 2.30.2
--
- Arnaldo
next prev parent reply other threads:[~2021-09-27 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 2:13 [PATCH dwarves v2 0/2] generate BTF_KIND_TAG types from DW_TAG_LLVM_annotation dwarf tags Yonghong Song
2021-09-22 2:13 ` [PATCH dwarves v2 1/2] dwarf_loader: parse dwarf tag DW_TAG_LLVM_annotation Yonghong Song
2021-09-22 2:13 ` [PATCH dwarves v2 2/2] btf_encoder: generate BTF_KIND_TAG from llvm annotations Yonghong Song
2021-09-27 20:40 ` Arnaldo Carvalho de Melo [this message]
2021-09-27 20:59 ` [PATCH dwarves v2 0/2] generate BTF_KIND_TAG types from DW_TAG_LLVM_annotation dwarf tags Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVIsKZTWlDugv3Yz@kernel.org \
--to=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dwarves@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).