From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
lorenzo.bianconi@redhat.com, davem@davemloft.net, ast@kernel.org,
daniel@iogearbox.net, shayagr@amazon.com,
john.fastabend@gmail.com, dsahern@kernel.org, brouer@redhat.com,
echaudro@redhat.com, jasowang@redhat.com,
alexander.duyck@gmail.com, saeed@kernel.org,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
tirthendu.sarkar@intel.com, toke@redhat.com
Subject: Re: [PATCH v15 bpf-next 17/18] net: xdp: introduce bpf_xdp_pointer utility routine
Date: Mon, 11 Oct 2021 20:35:28 +0200 [thread overview]
Message-ID: <YWSD8O0lw6kaGmRD@lore-desk> (raw)
In-Reply-To: <20211008181026.0b94149a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
> On Fri, 8 Oct 2021 14:49:55 +0200 Lorenzo Bianconi wrote:
> > +BPF_CALL_4(bpf_xdp_load_bytes, struct xdp_buff *, xdp, u32, offset,
> > + void *, buf, u32, len)
> > +{
> > + void *ptr;
> > +
> > + if (!buf)
> > + return -EINVAL;
>
> Can we make the verifier ensure it's not NULL?
I guess we can use ARG_PTR_TO_MEM instead of ARG_PTR_TO_UNINIT_MEM
>
> > + ptr = bpf_xdp_pointer(xdp, offset, len, buf);
> > + if (ptr != buf)
> > + memcpy(buf, ptr, len);
>
> Don't we need to return an error in case offset + length > frame size?
ack, I will fix it.
Regards,
Lorenzo
>
> > + return 0;
> > +}
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-10-11 18:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 12:49 [PATCH v15 bpf-next 00/18] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 01/18] net: skbuff: add size metadata to skb_shared_info for xdp Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 02/18] xdp: introduce flags field in xdp_buff/xdp_frame Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 03/18] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 04/18] net: mvneta: simplify mvneta_swbm_add_rx_fragment management Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 05/18] net: xdp: add xdp_update_skb_shared_info utility routine Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 06/18] net: marvell: rely on " Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 07/18] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 08/18] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 09/18] net: mvneta: enable jumbo frames for XDP Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 10/18] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 11/18] bpf: introduce bpf_xdp_get_buff_len helper Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 12/18] bpf: add multi-buffer support to xdp copy helpers Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 13/18] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 14/18] bpf: introduce multibuff support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 15/18] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 16/18] bpf: update xdp_adjust_tail selftest to include multi-buffer Lorenzo Bianconi
2021-10-08 12:49 ` [PATCH v15 bpf-next 17/18] net: xdp: introduce bpf_xdp_pointer utility routine Lorenzo Bianconi
2021-10-09 1:10 ` Jakub Kicinski
2021-10-11 18:35 ` Lorenzo Bianconi [this message]
2021-10-08 12:49 ` [PATCH v15 bpf-next 18/18] bpf: introduce bpf_xdp_{load,store}_bytes selftest Lorenzo Bianconi
2021-10-09 1:14 ` [PATCH v15 bpf-next 00/18] mvneta: introduce XDP multi-buffer support Jakub Kicinski
2021-10-09 13:00 ` Toke Høiland-Jørgensen
2021-10-11 9:48 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWSD8O0lw6kaGmRD@lore-desk \
--to=lorenzo@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=echaudro@redhat.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=shayagr@amazon.com \
--cc=tirthendu.sarkar@intel.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).