From: Roman Gushchin <guro@fb.com>
To: <quanyang.wang@windriver.com>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <ming.lei@redhat.com>, <mkoutny@suse.com>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [V2][PATCH] cgroup: fix memory leak caused by missing cgroup_bpf_offline
Date: Thu, 21 Oct 2021 18:30:24 -0700 [thread overview]
Message-ID: <YXIUMJWrXUcrvZf5@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20211018075623.26884-1-quanyang.wang@windriver.com>
On Mon, Oct 18, 2021 at 03:56:23PM +0800, quanyang.wang@windriver.com wrote:
> From: Quanyang Wang <quanyang.wang@windriver.com>
>
> When enabling CONFIG_CGROUP_BPF, kmemleak can be observed by running
> the command as below:
>
> $mount -t cgroup -o none,name=foo cgroup cgroup/
> $umount cgroup/
>
> unreferenced object 0xc3585c40 (size 64):
> comm "mount", pid 425, jiffies 4294959825 (age 31.990s)
> hex dump (first 32 bytes):
> 01 00 00 80 84 8c 28 c0 00 00 00 00 00 00 00 00 ......(.........
> 00 00 00 00 00 00 00 00 6c 43 a0 c3 00 00 00 00 ........lC......
> backtrace:
> [<e95a2f9e>] cgroup_bpf_inherit+0x44/0x24c
> [<1f03679c>] cgroup_setup_root+0x174/0x37c
> [<ed4b0ac5>] cgroup1_get_tree+0x2c0/0x4a0
> [<f85b12fd>] vfs_get_tree+0x24/0x108
> [<f55aec5c>] path_mount+0x384/0x988
> [<e2d5e9cd>] do_mount+0x64/0x9c
> [<208c9cfe>] sys_mount+0xfc/0x1f4
> [<06dd06e0>] ret_fast_syscall+0x0/0x48
> [<a8308cb3>] 0xbeb4daa8
>
> This is because that since the commit 2b0d3d3e4fcf ("percpu_ref: reduce
> memory footprint of percpu_ref in fast path") root_cgrp->bpf.refcnt.data
> is allocated by the function percpu_ref_init in cgroup_bpf_inherit which
> is called by cgroup_setup_root when mounting, but not freed along with
> root_cgrp when umounting. Adding cgroup_bpf_offline which calls
> percpu_ref_kill to cgroup_kill_sb can free root_cgrp->bpf.refcnt.data in
> umount path.
>
> This patch also fixes the commit 4bfc0bb2c60e ("bpf: decouple the lifetime
> of cgroup_bpf from cgroup itself"). A cgroup_bpf_offline is needed to do a
> cleanup that frees the resources which are allocated by cgroup_bpf_inherit
> in cgroup_setup_root.
>
> And inside cgroup_bpf_offline, cgroup_get() is at the beginning and
> cgroup_put is at the end of cgroup_bpf_release which is called by
> cgroup_bpf_offline. So cgroup_bpf_offline can keep the balance of
> cgroup's refcount.
>
> Fixes: 2b0d3d3e4fcf ("percpu_ref: reduce memory footprint of percpu_ref in fast path")
> Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from cgroup itself")
> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> ---
> V1 ---> V2:
> 1. As per Daniel's suggestion, add description to commit msg about the
> balance of cgroup's refcount in cgroup_bpf_offline.
> 2. As per Michal's suggestion, add tag "Fixes: 4bfc0bb2c60e" and add
> description about it.
> 3. Fix indentation on the percpu_ref_is_dying line.
Acked-by: Roman Gushchin <guro@fb.com>
The fix looks correct, two fixes tag are fine too, if only it won't
confuse scripts picking up patches for stable backports.
In fact, it's a very cold path, which is arguably never hit in the real
life. On cgroup v2 it's not an issue. I'm not sure we need a stable
backport at all, only if it creates a noise for some automation tests.
Quanyang, out of curiosity, how did you find it?
Anyway, thanks for catching and fixing it!
Roman
next prev parent reply other threads:[~2021-10-22 1:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 7:56 [V2][PATCH] cgroup: fix memory leak caused by missing cgroup_bpf_offline quanyang.wang
2021-10-18 9:02 ` Ming Lei
2021-10-18 10:06 ` Quanyang Wang
2021-10-18 12:59 ` Ming Lei
2021-10-19 10:41 ` Quanyang Wang
2021-10-19 17:10 ` Michal Koutný
2021-10-20 2:17 ` Ming Lei
2021-10-20 5:22 ` Quanyang Wang
2021-10-20 17:28 ` Michal Koutný
2021-10-22 11:03 ` Quanyang Wang
2021-10-20 5:16 ` Quanyang Wang
2021-10-19 10:41 ` Quanyang Wang
2021-10-22 1:30 ` Roman Gushchin [this message]
2021-10-22 11:55 ` Quanyang Wang
2021-10-22 21:29 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXIUMJWrXUcrvZf5@carbon.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=netdev@vger.kernel.org \
--cc=quanyang.wang@windriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).