From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA745C433F5 for ; Tue, 23 Nov 2021 23:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232825AbhKWXkH (ORCPT ); Tue, 23 Nov 2021 18:40:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:40286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbhKWXkH (ORCPT ); Tue, 23 Nov 2021 18:40:07 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0BD8B60FE6; Tue, 23 Nov 2021 23:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637710618; bh=goEt95AjqVyH7lqA1ttHp+MQMzGgIEXhQBLPDNXZlQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L14BQu617FKOQu5F0ATt5iA79RaSYzq3A/GUpoGfOMWJU0+1J3hd3hURai18zIw38 y8G/yuU0jMtPboFPafIqydLPeqF6YLZVvyijpLo6vAh+M7LMALzghKpWmiwxFw3WqI 5iOI+GS65jxd1iWGj8SIeBGwPt0bqs6WJSpiEoJ2yFKrbuHSMf2LZlj8I6xeJoUnjl k3HsQcO3USsN1TUGbJuQqDnUglWMmG1t0WHR3u1BNq8KemxJC1ZlPn09nfM38LDMSU uH9Wd4bXIV7noDdh/1hwuoyt5Ml3HHXhXr9bnlD/sKlQogh14oLVjfw4AoK8Pr1sID 0/wK6CEIq4IxA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id DB88740002; Tue, 23 Nov 2021 20:36:55 -0300 (-03) Date: Tue, 23 Nov 2021 20:36:55 -0300 From: Arnaldo Carvalho de Melo To: Andrii Nakryiko Cc: Yonghong Song , Arnaldo Carvalho de Melo , dwarves@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , bpf , Daniel Borkmann , Kernel Team Subject: Re: [PATCH dwarves v2 0/4] btf: support btf_type_tag attribute Message-ID: References: <20211123045612.1387544-1-yhs@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Em Tue, Nov 23, 2021 at 10:32:18AM -0800, Andrii Nakryiko escreveu: > On Mon, Nov 22, 2021 at 8:56 PM Yonghong Song wrote: > > > > btf_type_tag is a new llvm type attribute which is used similar > > to kernel __user/__rcu attributes. The format of btf_type_tag looks like > > __attribute__((btf_type_tag("tag1"))) > > For the case where the attribute applied to a pointee like > > #define __tag1 __attribute__((btf_type_tag("tag1"))) > > #define __tag2 __attribute__((btf_type_tag("tag2"))) > > int __tag1 * __tag1 __tag2 *g; > > the information will be encoded in dwarf. > > > > In BTF, the attribute is encoded as a new kind > > BTF_KIND_TYPE_TAG and latest bpf-next supports it. > > > > The patch added support in pahole, specifically > > converts llvm dwarf btf_type_tag attributes to > > BTF types. Please see individual patches for details. > > > > Changelog: > > v1 -> v2: > > - reorg an if condition to reduce nesting level. > > - add more comments to explain how to chain type tag types. > > > > Yonghong Song (4): > > libbpf: sync with latest libbpf repo > > dutil: move DW_TAG_LLVM_annotation definition to dutil.h > > dwarf_loader: support btf_type_tag attribute > > btf_encoder: support btf_type_tag attribute > > > > I thought that v1 was already applied, but either way LGTM. I'm not To the next branch, and the libbpf pahole CI is failing, since a few days, can you please take a look? > super familiar with the DWARF loader parts, so I mostly just read it > very superficially :) I replaced the patches that changed, re-added the S-o-B for Yonghong and tested it with llvm-project HEAD. > Acked-by: Andrii Nakryiko Adding it to the csets. Thanks! - Arnaldo > > > btf_encoder.c | 7 +++ > > dutil.h | 4 ++ > > dwarf_loader.c | 140 ++++++++++++++++++++++++++++++++++++++++++++++--- > > dwarves.h | 38 +++++++++++++- > > lib/bpf | 2 +- > > pahole.c | 8 +++ > > 6 files changed, 190 insertions(+), 9 deletions(-) > > > > -- > > 2.30.2 > > -- - Arnaldo