From: Christoph Hellwig <hch@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
Nicholas Piggin <npiggin@gmail.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Song Liu <song@kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
X86 ML <x86@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"andrii@kernel.org" <andrii@kernel.org>,
Kernel Team <Kernel-team@fb.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>
Subject: Re: [PATCH bpf 0/4] introduce HAVE_ARCH_HUGE_VMALLOC_FLAG for bpf_prog_pack
Date: Tue, 5 Apr 2022 00:07:34 -0700 [thread overview]
Message-ID: <YkvqtvNFtzDNkEhy@infradead.org> (raw)
In-Reply-To: <6AA91984-7DF3-4820-91DF-DD6CA251B638@fb.com>
On Fri, Apr 01, 2022 at 10:22:00PM +0000, Song Liu wrote:
> >> Please fix the underlying issues instead of papering over them and
> >> creating a huge maintainance burden for others.
>
> After reading the code a little more, I wonder what would be best strategy.
> IIUC, most of the kernel is not ready for huge page backed vmalloc memory.
> For example, all the module_alloc cannot work with huge pages at the moment.
> And the error Paul Menzel reported in drm_fb_helper.c will probably hit
> powerpc with 5.17 kernel as-is? (trace attached below)
>
> Right now, we have VM_NO_HUGE_VMAP to let a user to opt out of huge pages.
> However, given there are so many users of vmalloc, vzalloc, etc., we
> probably do need a flag for the user to opt-in?
>
> Does this make sense? Any recommendations are really appreciated.
I think there is multiple aspects here:
- if we think that the kernel is not ready for hugepage backed vmalloc
in general we need to disable it in powerpc for now.
- if we think even in the longer run only some users can cope with
hugepage backed vmalloc we need to turn it into an opt-in in
general and not just for x86
- there still to appear various unresolved underlying x86 specific
issues that need to be fixed either way
next prev parent reply other threads:[~2022-04-05 7:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220330225642.1163897-1-song@kernel.org>
[not found] ` <20220330225642.1163897-3-song@kernel.org>
2022-03-30 23:40 ` [PATCH bpf 2/4] vmalloc: introduce HAVE_ARCH_HUGE_VMALLOC_FLAG Edgecombe, Rick P
2022-03-31 0:26 ` Song Liu
[not found] ` <20220330225642.1163897-2-song@kernel.org>
2022-03-30 23:47 ` [PATCH bpf 1/4] x86: disable HAVE_ARCH_HUGE_VMALLOC Thomas Gleixner
[not found] ` <20220330225642.1163897-4-song@kernel.org>
2022-03-30 23:54 ` [PATCH bpf 3/4] x86: select HAVE_ARCH_HUGE_VMALLOC_FLAG for X86_64 Thomas Gleixner
2022-03-31 0:30 ` Song Liu
[not found] ` <20220330225642.1163897-5-song@kernel.org>
2022-03-31 0:00 ` [PATCH bpf 4/4] bpf: use __vmalloc_node_range() with VM_TRY_HUGE_VMAP for bpf_prog_pack Thomas Gleixner
2022-03-31 0:31 ` Song Liu
2022-03-31 0:04 ` [PATCH bpf 0/4] introduce HAVE_ARCH_HUGE_VMALLOC_FLAG " Edgecombe, Rick P
2022-03-31 0:46 ` Song Liu
2022-03-31 16:19 ` Edgecombe, Rick P
2022-03-31 5:37 ` Christoph Hellwig
2022-03-31 23:59 ` Song Liu
2022-04-01 22:22 ` Song Liu
2022-04-05 7:07 ` Christoph Hellwig [this message]
2022-04-05 23:54 ` Song Liu
2022-04-07 19:57 ` Song Liu
2022-04-08 10:08 ` Claudio Imbrenda
2022-04-08 21:22 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkvqtvNFtzDNkEhy@infradead.org \
--to=hch@infradead.org \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=imbrenda@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=pmenzel@molgen.mpg.de \
--cc=rick.p.edgecombe@intel.com \
--cc=song@kernel.org \
--cc=songliubraving@fb.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).