From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bpf-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 438D1C6FD1D
	for <bpf@archiver.kernel.org>; Mon, 27 Mar 2023 17:47:38 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229492AbjC0Rrh (ORCPT <rfc822;bpf@archiver.kernel.org>);
        Mon, 27 Mar 2023 13:47:37 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51594 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229482AbjC0Rrg (ORCPT <rfc822;bpf@vger.kernel.org>);
        Mon, 27 Mar 2023 13:47:36 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC40D170C;
        Mon, 27 Mar 2023 10:47:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type:
        MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=fmENmbS6YfOGCbil7lKj3DcV2u8EJhaYQuM6f42l51Y=; b=nhWgKJZdcJr3P9s6ucypYywMfE
        4Kt1OJhrAyyN06VLI/MFIvlrlLN5hdFHHyyzncvo1caPmR725nd9bjgxoeaVDvbiF3rm4UzIqVCXa
        u6khJw9B9dTbNUQAfusDEdSipEZu3L/qxKmW91j4BLoqCKktu/sXGMdK5+CF7Jd9NvsOgh6tGzNG0
        2BeoQSw8+lmEkihHVIgidX7dCg2701aOMxqhixXsH89OSoZ65PHjG/ftQ/qtu6TlBoUGBoEoIIF5V
        BPDheF5+Q07wxCQqH5WoPUnGg6+kwxYCDmchHEqek6K4ybBcjRGxXtXsdwaAi3t00QIiGtoH23jWS
        g3SySQJw==;
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux))
        id 1pgqwQ-00BwSV-0n;
        Mon, 27 Mar 2023 17:47:34 +0000
Date:   Mon, 27 Mar 2023 10:47:34 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Viktor Malik <vmalik@redhat.com>
Cc:     bpf@vger.kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        John Fastabend <john.fastabend@gmail.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH bpf-next] kallsyms: move module-related functions under
 correct configs
Message-ID: <ZCHWtptOwPPtUe+u@bombadil.infradead.org>
References: <20230327161251.1129511-1-vmalik@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230327161251.1129511-1-vmalik@redhat.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk
List-ID: <bpf.vger.kernel.org>
X-Mailing-List: bpf@vger.kernel.org

On Mon, Mar 27, 2023 at 06:12:51PM +0200, Viktor Malik wrote:
> Functions for searching module kallsyms should have non-empty
> definitions only if CONFIG_MODULES=y and CONFIG_KALLSYMS=y. Until now,
> only CONFIG_MODULES check was used for many of these, which may have
> caused complilation errors on some configs.
> 
> This patch moves all relevant functions under the correct configs.
> 
> Signed-off-by: Viktor Malik <vmalik@redhat.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303181535.RFDCnz3E-lkp@intel.com/

Thanks Viktor!  Does this fix something from an existing commit? If so
which one?  The commit log should mention it.

  LUis